Review Request 120612: Krita: save settings for ellipse tool

[Scott Petrovic]

> On Oct. 19, 2014, 10:06 p.m., Sven Langkamp wrote:
> > Another thing I noticed: When you have accidently saved with no fill and no outline, it appears that the tool stopped working and you wonder what happened. Maybe add a notification when that happens in the shape tools.
> 
> Scott Petrovic wrote:
>     good ideas. I will modify and resubmit.

I figured out how to refactor the code so it uses the base class more. For the notification idea, maybe it would be better if the tool options were smarter when it loads. If the tool is  activated and it sees that there is no outline and no fill type, it can automatically set the outline type to brush. Doing that would eliminate the problem with everything being empty. Of course the person could change it back, but at least it wouldn't happen right when Krita loads.


- Scott


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120612/#review68730
-----------------------------------------------------------


On Oct. 17, 2014, 4:06 a.m., Scott Petrovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120612/
> -----------------------------------------------------------
> 
> (Updated Oct. 17, 2014, 4:06 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> load/save settings for ellipse tool
> 
> 
> Diffs
> -----
> 
>   krita/plugins/tools/defaulttools/kis_tool_ellipse.h f2ec9d1 
>   krita/plugins/tools/defaulttools/kis_tool_ellipse.cc bb74f66 
> 
> Diff: https://git.reviewboard.kde.org/r/120612/diff/
> 
> 
> Testing
> -------
> 
> loading and saving seemed to work.
> 
> 
> Thanks,
> 
> Scott Petrovic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141021/f4bbccca/attachment.htm>