Review Request 120634: Added possibility of painting kexi report rect elements in all directions

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120634/#review68679
-----------------------------------------------------------


Works great!
In addition to code suggestions, one remark: when I'm drawing rectangle past the section boundaries as on the screenshot, http://wstaw.org/m/2014/10/19/plasma-desktopTS5918.png the size of the created element is equal to the default one. It should be just equal to the rectangle that I draw, cut to the section's boundary. This may be addressed somewhere in the same code.


libs/koreport/items/check/KoReportDesignerItemCheck.cpp
<https://git.reviewboard.kde.org/r/120634/#comment47866>

    Because it's copied everywhere (except non-rect elements such as line) I wonder why is this line so complicated.
    How about having just KoReportDesignerItemRectBase::setSceneRect(KoReportDesigner *d)?
    This method itself could then use countProperPoint(*d) and minimumSize(*d).
    Then make countProperPoint() private.
    And rename somehow to properPressPoint().


- Jarosław Staniek


On Oct. 18, 2014, 8:26 a.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120634/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2014, 8:26 a.m.)
> 
> 
> Review request for Calligra, Michal Poteralski, Adam Pigg, Jarosław Staniek, and Radosław Wicik.
> 
> 
> Bugs: 334967
>     http://bugs.kde.org/show_bug.cgi?id=334967
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Before there was only possible to paint kexi report rect element from leftup to rightdown. Now it's possible to paint the report element in any directio
> 
> 
> Diffs
> -----
> 
>   plugins/reporting/web/KoReportDesignerItemWeb.cpp b57f3c4 
>   libs/koreport/items/check/KoReportDesignerItemCheck.cpp ac62861 
>   libs/koreport/items/field/KoReportDesignerItemField.cpp f386f9b 
>   libs/koreport/items/image/KoReportDesignerItemImage.cpp b129299 
>   libs/koreport/items/label/KoReportDesignerItemLabel.cpp 8bebbd2 
>   libs/koreport/items/text/KoReportDesignerItemText.cpp 7af69c4 
>   libs/koreport/wrtembed/KoReportDesigner.h d27e263 
>   libs/koreport/wrtembed/KoReportDesigner.cpp 2e1bd50 
>   libs/koreport/wrtembed/KoReportDesignerItemRectBase.h 501172a 
>   libs/koreport/wrtembed/KoReportDesignerItemRectBase.cpp 73b7a70 
>   plugins/reporting/barcode/KoReportDesignerItemBarcode.cpp 43acbd0 
>   plugins/reporting/maps/KoReportDesignerItemMaps.cpp d97a5ea 
> 
> Diff: https://git.reviewboard.kde.org/r/120634/diff/
> 
> 
> Testing
> -------
> 
> Possible to paint kexi report rect elements in any direction
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141018/a56670ea/attachment.htm>