Review Request 120645: Msword filter - Fix the page borders when there is a header/footer included in margin

[Pierre Ducroquet]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120645/
-----------------------------------------------------------

(Updated Oct. 18, 2014, 2:13 p.m.)


Review request for Calligra and Camilla Boemann.


Changes
-------

Why do half the work, fix the footers too...


Summary (updated)
-----------------

Msword filter - Fix the page borders when there is a header/footer included in margin


Bugs: 337675
    http://bugs.kde.org/show_bug.cgi?id=337675


Repository: calligra


Description (updated)
-------

Check the msword fIncludeHeader and fIncludeFooter settings to properly calculate the page top and bottom margin.


Diffs (updated)
-----

  filters/words/msword-odf/document.cpp 8ba787293df62e595746eb4de9ee3069d2b6e009 

Diff: https://git.reviewboard.kde.org/r/120645/diff/


Testing
-------

Check with the file of bug report 337675 : no more crash.
Check with cstester and ~50 .doc files : the changes are always closer to a PDF exported by word than our previous result.


Thanks,

Pierre Ducroquet

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141018/7763730a/attachment.htm>