Review Request 120638: Krita: save settings for fill tool

Scott Petrovic scottpetrovic at gmail.com
Sat Oct 18 03:48:20 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120638/
-----------------------------------------------------------

Review request for Calligra.


Repository: calligra


Description
-------

load/save settings for fill tool. Note that I later found out I missed a call to activate to the base class. I wasn't sure how to add two commits to the review board, so I attached an additional patch that has the fix. 


Diffs
-----

  krita/plugins/tools/defaulttools/kis_tool_fill.h 6c90b0a 
  krita/plugins/tools/defaulttools/kis_tool_fill.cc 7940eb1 

Diff: https://git.reviewboard.kde.org/r/120638/diff/


Testing
-------

load/save files from the kritarc


File Attachments
----------------

extra patch to add activate base class
  https://git.reviewboard.kde.org/media/uploaded/files/2014/10/18/0afa6cea-1f24-4819-92f9-fd1986616bbd__0003-call-base-class-on-fill-tool-activate.patch


Thanks,

Scott Petrovic

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141018/6f3232f8/attachment.htm>


More information about the calligra-devel mailing list