Review Request 120609: The PixmapCacheSheetView crashes after the getTile API retuns from the QCache the QImage, but its use is deprecated

[Philip Van Hoof]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120609/
-----------------------------------------------------------

(Updated Oct. 16, 2014, 8:15 p.m.)


Review request for Calligra.


Changes
-------

Grammar


Bugs: 339921
    http://bugs.kde.org/show_bug.cgi?id=339921


Repository: calligra


Description (updated)
-------

The PixmapCacheSheetView crashes after the getTile API returns from the QCache, the QImage, but its use is deprecated


Diffs
-----

  sheets/part/CanvasItem.cpp 9a5d77a 

Diff: https://git.reviewboard.kde.org/r/120609/diff/


Testing
-------

More on the bug and crash explained here:

https://bugs.kde.org/show_bug.cgi?id=339921

I think it's better to just stop using PixmapCacheSheetView and simply use SheetView directly in CanvasItem.


Thanks,

Philip Van Hoof

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141016/833f01bd/attachment.htm>