Review Request 119612: Implement an MDI interface for Krita

Boudewijn Rempt boud at valdyas.org
Wed Oct 15 17:59:17 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119612/
-----------------------------------------------------------

(Updated Oct. 15, 2014, 4:58 p.m.)


Review request for Calligra.


Changes
-------

Now the menus are correctly created, shortcuts work and the modifying a document enables the save actions. It's ready for user-testing.


Remaining problems: 

* sketch is broken
* gemini is broken
* kritaanimation is broken.


Repository: calligra


Description
-------

As discussed at the calligra sprint, this isn't a full port of all of Calligra to MDI. This patch contains a stripped copy of komain, renamed to komvc and made local for Krita. It also doesn't contain the stripped fork of KXMLGui, though I still intend to make Krita independent of KXMLGui in time for the KF5 port. There is one global change and that puts the tool option widgets list for the toolbox in a QPointer.

In Krita, KisView is split into KisMainWindow, KisView and KisImageView. An image can be shown in more than one view, more than one view can be shown in a mainwindow, and more than one mainwindow can be open.

KisPart2 inherits KoPart and keeps the list of views, documents and mainwindows.

KisMainWindow is the mainwindow, inheriting KoMainWindow. It it responsible for managing the list of subwindows in, currently, a QMdiArea set to tabbed mode by default.

KisView2 is a pure KXMLGuiClient that adds actions and so on to KoMainWindow. It still has a lot of pass-through methods because all of Krita queries KisView2 for things like the active document, image, node, selection etc.

KisImageView is a view on a single image. It owns a canvas widget and manages zoom levels.

Problems:

* I had to disable sketch and gemini because I haven't yet been able to figure out how to port those applications to the KisImageView/KisView split. Especially, should the sync event handling be in KisMainWindow or KisImageView?

* XXX: KOMVC marks places where code has been commented out, mostly to do with canvas decorations like assistants and color management.

* Changes are as minimal as possible, so no cleanup yet of documentation, coding style and so on.

* There still are quite a few bugs that need fixing. 

* Krita doesn't actually start with this version...


Diffs (updated)
-----

  libs/basicflakes/plugin/CMakeLists.txt 70e3d91 
  libs/basicflakes/tools/KoCreatePathTool.h 1496a49 
  libs/basicflakes/tools/KoCreatePathTool.cpp 3829d82 
  libs/basicflakes/tools/KoPencilTool.h f7d8b12 
  libs/basicflakes/tools/KoPencilTool.cpp 264b5db 
  libs/flake/KoCanvasBase.h 243003b 
  libs/flake/KoCanvasBase.cpp 4949402 
  libs/flake/KoCanvasController.h 804a1e4 
  libs/flake/KoCanvasControllerWidget.h a822ad6 
  libs/flake/KoCanvasControllerWidget.cpp fa3eaa6 
  libs/flake/KoToolBase.h 18faa58 
  libs/flake/KoToolBase.cpp 963dfad 
  libs/flake/KoToolBase_p.h f79e556 
  libs/flake/KoToolManager.cpp 5d4da91 
  libs/flake/tools/KoPathTool.h 6577f76 
  libs/flake/tools/KoPathTool.cpp c475876 
  libs/kopageapp/KoPAPrintJob.h e6762a1 
  libs/kopageapp/KoPAView.cpp 6e0b519 
  libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h e55c0bb 
  libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp 34e252a 
  libs/koproperty/editors/combobox.cpp 26a2ec3 
  libs/kotext/CMakeLists.txt 3931224 
  libs/main/CMakeLists.txt 2affede 
  libs/main/KoDockerManager.h f465edf 
  libs/main/KoDockerManager.cpp ec93c7c 
  libs/main/KoDocument.cpp 9d5d36f 
  libs/main/KoGlobal.h 89f5429 
  libs/main/KoGlobal.cpp 80c3b2e 
  libs/main/KoModeBox.cpp 57c64cc 
  libs/main/KoModeBox_p.h 2f0d882 
  libs/main/KoToolDocker_p.h 35037d0 
  libs/main/KoToolDocker_p.cpp 9039f40 
  libs/main/KoView.cpp 4770dcc 
  libs/rdf/KoDocumentRdfEditWidget.cpp 7845f5a 
  libs/widgets/CMakeLists.txt 2268054 
  libs/widgets/KoGlobal.h PRE-CREATION 
  libs/widgets/KoGlobal.cpp PRE-CREATION 
  plugins/artistictextshape/ArtisticTextTool.h 748300f 
  plugins/artistictextshape/ArtisticTextTool.cpp 48f40b1 
  plugins/defaultTools/connectionTool/ConnectionTool.h 4abb560 
  plugins/defaultTools/connectionTool/ConnectionTool.cpp 4a05b1e 
  plugins/defaultTools/defaulttool/DefaultTool.h dca6ae8 
  plugins/defaultTools/defaulttool/DefaultTool.cpp 40d34c1 
  plugins/defaultTools/guidestool/GuidesTool.h 5a74b12 
  plugins/defaultTools/guidestool/GuidesTool.cpp ffa2fa5 
  plugins/pictureshape/CMakeLists.txt 175cb45 
  plugins/textshape/CMakeLists.txt 1e32101 
  plugins/textshape/ReferencesTool.h 02d8c51 
  plugins/textshape/ReferencesTool.cpp be7f558 
  plugins/textshape/ReviewTool.h 66e0e9d 
  plugins/textshape/ReviewTool.cpp 24b82f8 
  plugins/textshape/TextTool.h 5e01e02 
  plugins/textshape/TextTool.cpp d92fc92 
  sheets/RowColumnFormat.cpp 9df89a4 
  sheets/dialogs/ConditionalDialog.cpp cb291bf 
  sheets/part/View.cpp 9d80cf0 
  sheets/shape/TableTool.h 96f29a8 
  sheets/shape/TableTool.cpp f16dfb2 
  sheets/ui/CellToolBase.h 58e0eab 
  sheets/ui/CellToolBase.cpp 0f19cab 
  stage/part/tools/animationtool/KPrAnimationTool.h 2b49ca1 
  stage/part/tools/animationtool/KPrAnimationTool.cpp 0c1d614 
  words/part/CMakeLists.txt 0b2c647 
  words/part/dialogs/KWPrintingDialog.h 87b1d71 
  words/part/pagetool/KWPageTool.h 45ad7d5 
  words/part/pagetool/KWPageTool.cpp 7935390 
  krita/ui/tool/kis_delegated_tool.h c63c6f9 
  krita/ui/tool/kis_figure_painting_tool_helper.h cf71d02 
  krita/ui/tool/kis_figure_painting_tool_helper.cpp 3464420 
  krita/ui/tool/kis_resources_snapshot.h 95fd8a4 
  krita/ui/tool/kis_resources_snapshot.cpp 94ed724 
  krita/ui/tool/kis_tool.cc 9429905 
  krita/ui/tool/kis_tool_freehand.h eb72cf4 
  krita/ui/tool/kis_tool_freehand.cc 76a0ce0 
  krita/ui/tool/kis_tool_freehand_helper.h 3ab5701 
  krita/ui/tool/kis_tool_freehand_helper.cpp bda74bb 
  krita/ui/tool/kis_tool_paint.cc 27a1bd3 
  krita/ui/tool/kis_tool_polyline_base.cpp 100c2df 
  krita/ui/tool/kis_tool_shape.cc 3e4c095 
  krita/ui/wdgsplash.ui PRE-CREATION 
  krita/ui/widgets/kis_animation_selector.h 9afac63 
  krita/ui/widgets/kis_animation_selector.cpp 7a7c08d 
  krita/ui/widgets/kis_custom_image_widget.h 125eb09 
  krita/ui/widgets/kis_custom_image_widget.cc 1579501 
  krita/ui/widgets/kis_image_from_clipboard_widget.h 3b8b2bb 
  krita/ui/widgets/kis_image_from_clipboard_widget.cpp fdf2fc4 
  krita/ui/widgets/kis_progress_widget.h 9f77df4 
  krita/ui/widgets/kis_scratch_pad.cpp 6c85e67 
  krita/wdgsplash.ui bf6a9eb 
  libs/basicflakes/CMakeLists.txt 05d9692 
  krita/ui/kis_splash_screen.cpp PRE-CREATION 
  krita/ui/kis_statusbar.h 5b5c74e 
  krita/ui/kis_statusbar.cc b7d2a96 
  krita/ui/kis_tooltip_manager.cpp ea0f377 
  krita/ui/kis_view2.h 278a9ff 
  krita/ui/kis_view2.cpp a8d309f 
  krita/ui/kis_zoom_manager.h a4ea1a6 
  krita/ui/kis_zoom_manager.cc e86e4fd 
  krita/ui/kranim/kis_kranim_saver.cpp 1ba0a16 
  krita/ui/operations/kis_operation_ui_widget_factory.h 8821d82 
  krita/ui/tests/CMakeLists.txt a5c3301 
  krita/ui/tests/fill_processing_visitor_test.cpp 74d83aa 
  krita/ui/tests/kis_action_manager_test.cpp bd3171f 
  krita/ui/tests/kis_doc2_test.cpp 1d58b9d 
  krita/ui/tests/kis_zoom_and_pan_test.cpp bc5b9ef 
  krita/ui/kis_aboutdata.cpp PRE-CREATION 
  krita/ui/kis_action.h 18cca90 
  krita/ui/kis_action.cpp dd143de 
  krita/ui/kis_action_manager.h ab7816f 
  krita/ui/kis_action_manager.cpp 4562d41 
  krita/ui/kis_animation_doc.h c5c4ab6 
  krita/ui/kis_animation_doc.cpp b0518d9 
  krita/ui/kis_animation_factory.cpp eeb770b 
  krita/ui/kis_animation_part.h 03cad7d 
  krita/ui/kis_animation_part.cpp f8e9d35 
  krita/ui/kis_animation_player.cpp 979bf1d 
  krita/ui/kis_canvas_controls_manager.h 5f514e7 
  krita/ui/kis_canvas_controls_manager.cpp 38280bf 
  krita/ui/kis_control_frame.h 5a379ab 
  krita/ui/kis_control_frame.cpp 1206df7 
  krita/ui/kis_doc2.h 5f9a62f 
  krita/ui/kis_doc2.cc 95f3703 
  krita/ui/kis_factory2.cc 4499da2 
  krita/ui/kis_filter_manager.h 666403f 
  krita/ui/kis_filter_manager.cc 46215af 
  krita/ui/kis_flipbook.cpp ec3eefe 
  krita/ui/kis_image_manager.h eaedb61 
  krita/ui/kis_image_manager.cc bedaab7 
  krita/ui/kis_image_view.h PRE-CREATION 
  krita/ui/kis_image_view.cpp PRE-CREATION 
  krita/ui/kis_layer_manager.h b0f5984 
  krita/ui/kis_layer_manager.cc 00bfd87 
  krita/ui/kis_main_window.h PRE-CREATION 
  krita/ui/kis_main_window.cpp PRE-CREATION 
  krita/ui/kis_mainwindow_observer.h PRE-CREATION 
  krita/ui/kis_mainwindow_observer.cpp PRE-CREATION 
  krita/ui/kis_mask_manager.h 9e8abec 
  krita/ui/kis_mask_manager.cc 266d4d2 
  krita/ui/kis_mirror_axis.h 36d4d89 
  krita/ui/kis_mirror_axis.cpp 0251bca 
  krita/ui/kis_node_manager.h de578be 
  krita/ui/kis_node_manager.cpp 75a3ece 
  krita/ui/kis_painting_assistants_decoration.h a2c1263 
  krita/ui/kis_painting_assistants_decoration.cpp dd65ec0 
  krita/ui/kis_painting_assistants_manager.h PRE-CREATION 
  krita/ui/kis_painting_assistants_manager.cpp PRE-CREATION 
  krita/ui/kis_paintop_box.h a3bec1c 
  krita/ui/kis_paintop_box.cc d0f6751 
  krita/ui/kis_part2.h ef9eba8 
  krita/ui/kis_part2.cpp a4b1a7a 
  krita/ui/kis_print_job.h 387d64b 
  krita/ui/kis_selection_decoration.h b29733a 
  krita/ui/kis_selection_decoration.cc 8ec9e03 
  krita/ui/kis_selection_manager.h 3e2f5bb 
  krita/ui/kis_selection_manager.cc e3518df 
  krita/ui/kis_splash_screen.h PRE-CREATION 
  krita/ui/dialogs/kis_dlg_filter.cpp fcb4817 
  krita/ui/dialogs/kis_dlg_generator_layer.h faaf305 
  krita/ui/dialogs/kis_dlg_generator_layer.cpp 64adb43 
  krita/ui/dialogs/kis_dlg_preferences.h a40b1f2 
  krita/ui/dialogs/kis_dlg_preferences.cc 21d7f19 
  krita/ui/flake/kis_dummies_facade_base.cpp 3d3694a 
  krita/ui/flake/kis_shape_controller.h 39ae1eb 
  krita/ui/flake/kis_shape_controller.cpp a0db22d 
  krita/ui/forms/wdggeneralsettings.ui 50a170b 
  krita/ui/input/kis_input_manager.cpp 0e80b0b 
  krita/ui/kis_aboutdata.h 06f7438 
  krita/plugins/extensions/dockers/flipbook/flipbookdocker_dock.cpp e5278f0 
  krita/plugins/extensions/dockers/historydocker/CMakeLists.txt 4cfa46c 
  krita/plugins/extensions/dockers/overview/overviewdocker_dock.cpp a3c76b6 
  krita/plugins/extensions/dockers/palettedocker/colorsetchooser.cpp 5c11bba 
  krita/plugins/extensions/dockers/palettedocker/palettedocker_dock.h 6b87247 
  krita/plugins/extensions/dockers/palettedocker/palettedocker_dock.cpp c260beb 
  krita/plugins/extensions/dockers/patterndocker/patterndocker_dock.h 82a8a36 
  krita/plugins/extensions/dockers/patterndocker/patterndocker_dock.cpp a959200 
  krita/plugins/extensions/dockers/presetdocker/presetdocker_dock.cpp 684f7b6 
  krita/plugins/extensions/dockers/specificcolorselector/specificcolorselector_dock.cc 59e438e 
  krita/plugins/extensions/dropshadow/kis_dropshadow_plugin.cc 1f920a4 
  krita/plugins/extensions/gmic/tests/CMakeLists.txt 1e8a958 
  krita/plugins/extensions/histogram/histogram.cc 80b9425 
  krita/plugins/extensions/imagesize/imagesize.cc ef35d56 
  krita/plugins/extensions/imagesplit/dlg_imagesplit.cpp 65026d4 
  krita/plugins/extensions/imagesplit/imagesplit.cpp dea4daf 
  krita/plugins/extensions/metadataeditor/metadataeditor.cc c8830cc 
  krita/plugins/extensions/offsetimage/offsetimage.cpp e46983f 
  krita/plugins/extensions/resourcemanager/resourcemanager.cpp 9d9065e 
  krita/plugins/extensions/resourcemanager/resourcemanager.rc 2fb607a 
  krita/plugins/extensions/resourcemanager/tests/CMakeLists.txt 1770760 
  krita/plugins/extensions/rotateimage/rotateimage.cc 383753b 
  krita/plugins/extensions/separate_channels/kis_channel_separator.cc 839d269 
  krita/plugins/extensions/separate_channels/kis_separate_channels_plugin.cc fcb6858 
  krita/plugins/extensions/shearimage/shearimage.cc 4dc9b65 
  krita/plugins/filters/tests/CMakeLists.txt cb25f6f 
  krita/plugins/filters/unsharp/tests/CMakeLists.txt 2f52b5f 
  krita/plugins/formats/exr/tests/CMakeLists.txt 166b2f9 
  krita/plugins/formats/jpeg/tests/CMakeLists.txt 0d28164 
  krita/plugins/formats/png/tests/CMakeLists.txt fdd4494 
  krita/plugins/formats/ppm/tests/CMakeLists.txt c5b3e36 
  krita/plugins/formats/psd/tests/CMakeLists.txt 90600ff 
  krita/plugins/formats/tiff/tests/CMakeLists.txt c51fa3b 
  krita/plugins/formats/xcf/tests/CMakeLists.txt 8afc593 
  krita/plugins/paintops/defaultpaintops/brush/tests/CMakeLists.txt 0344ebb 
  krita/plugins/paintops/defaultpaintops/brush/tests/kis_brushop_test.cpp b44a55d 
  krita/plugins/tools/defaulttools/kis_tool_ellipse.cc bb74f66 
  krita/plugins/tools/defaulttools/kis_tool_fill.cc 7940eb1 
  krita/plugins/tools/defaulttools/kis_tool_gradient.cc 6ffb0b5 
  krita/plugins/tools/defaulttools/kis_tool_line.cc 7fb29df 
  krita/plugins/tools/defaulttools/kis_tool_line_helper.h 57970fd 
  krita/plugins/tools/defaulttools/kis_tool_line_helper.cpp b19216b 
  krita/plugins/tools/defaulttools/kis_tool_move.cc d3d67e9 
  krita/plugins/tools/defaulttools/kis_tool_path.h 36db16a 
  krita/plugins/tools/defaulttools/kis_tool_path.cc ffbf5e7 
  krita/plugins/tools/defaulttools/kis_tool_rectangle.cc a00aa6a 
  krita/plugins/tools/defaulttools/tests/CMakeLists.txt 3e78eb2 
  krita/plugins/tools/selectiontools/kis_tool_select_path.h 0bb252b 
  krita/plugins/tools/selectiontools/kis_tool_select_path.cc f85feef 
  krita/plugins/tools/tool_crop/kis_tool_crop.cc 8149fb4 
  krita/plugins/tools/tool_perspectivegrid/kis_tool_perspectivegrid.h 32f72d5 
  krita/plugins/tools/tool_perspectivegrid/kis_tool_perspectivegrid.cc af48810 
  krita/plugins/tools/tool_polygon/kis_tool_polygon.cc 85a4367 
  krita/plugins/tools/tool_polyline/kis_tool_polyline.cc 2bb4254 
  krita/plugins/tools/tool_text/kis_tool_text.h e646d9f 
  krita/plugins/tools/tool_text/kis_tool_text.cc 9c799a5 
  krita/plugins/tools/tool_transform2/kis_tool_transform.cc 2e4b97a 
  krita/sdk/tests/stroke_testing_utils.cpp 366d262 
  krita/sdk/tests/ui_manager_test.h d70c36a 
  krita/sketch/CMakeLists.txt 46e0ba4 
  krita/sketch/kritasketch.rc f072234 
  krita/ui/CMakeLists.txt 1aa4f64 
  krita/ui/actions/kis_selection_action_factories.cpp 17094dc 
  krita/ui/canvas/kis_canvas2.h 3480834 
  krita/ui/canvas/kis_canvas2.cpp 60ade0b 
  krita/ui/canvas/kis_canvas_controller.h b022593 
  krita/ui/canvas/kis_canvas_controller.cpp c0a424c 
  krita/ui/canvas/kis_canvas_decoration.h 347ac08 
  krita/ui/canvas/kis_canvas_decoration.cc 9179d3f 
  krita/ui/canvas/kis_canvas_widget_base.cpp 02f0ab5 
  krita/ui/canvas/kis_grid_decoration.h PRE-CREATION 
  krita/ui/canvas/kis_grid_decoration.cpp PRE-CREATION 
  krita/ui/canvas/kis_grid_manager.h 042cc90 
  krita/ui/canvas/kis_grid_manager.cpp 8d5fe7c 
  krita/ui/canvas/kis_infinity_manager.h f22b555 
  krita/ui/canvas/kis_infinity_manager.cpp 18790b3 
  krita/ui/canvas/kis_paintop_transformation_connector.h 34c498a 
  krita/ui/canvas/kis_paintop_transformation_connector.cpp 06c8039 
  krita/ui/canvas/kis_perspective_grid_decoration.h PRE-CREATION 
  krita/ui/canvas/kis_perspective_grid_decoration.cpp PRE-CREATION 
  krita/ui/canvas/kis_perspective_grid_manager.h 96846f3 
  krita/ui/canvas/kis_perspective_grid_manager.cpp f7ad056 
  krita/ui/dialogs/kis_about_application.h PRE-CREATION 
  krita/ui/dialogs/kis_about_application.cpp PRE-CREATION 
  krita/ui/dialogs/kis_dlg_adjustment_layer.h 7da0215 
  krita/ui/dialogs/kis_dlg_adjustment_layer.cc f9aade0 
  krita/ui/dialogs/kis_dlg_filter.h 7237a3f 
  krita/plugins/extensions/dockers/channeldocker/channeldocker_dock.cpp 87be27c 
  krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.h 2007bc8 
  krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp 50227f5 
  krita/plugins/extensions/dockers/flipbook/flipbookdocker_dock.h 57b8ec6 
  krita/plugins/extensions/colorspaceconversion/colorspaceconversion.cc 3386add 
  krita/plugins/extensions/dockers/advancedcolorselector/kis_color_history.cpp 0deeb96 
  krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_base.cpp 6d5adeb 
  krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_ng_docker_widget.cpp d780279 
  krita/plugins/extensions/dockers/animator/animator_dock.cpp 7f6e4c4 
  krita/plugins/extensions/dockers/animator/onionskin_dock.cpp 360b110 
  krita/plugins/extensions/dockers/artisticcolorselector/artisticcolorselector_dock.h 292f510 
  krita/plugins/extensions/dockers/artisticcolorselector/artisticcolorselector_dock.cpp de633b4 
  krita/komvc/calligragitversion.h.cmake PRE-CREATION 
  krita/komvc/calligraversion.cpp PRE-CREATION 
  krita/komvc/calligraversion.h.cmake PRE-CREATION 
  krita/komvc/koDocumentInfoAboutWidget.ui PRE-CREATION 
  krita/komvc/koDocumentInfoAuthorWidget.ui PRE-CREATION 
  krita/komvc/komvc_export.h PRE-CREATION 
  krita/komvc/osx.stylesheet PRE-CREATION 
  krita/komvc/thememanager.h PRE-CREATION 
  krita/komvc/thememanager.cpp PRE-CREATION 
  krita/komvc/thememanager.rc PRE-CREATION 
  krita/krita.rc 50faa31 
  krita/libbrush/tests/CMakeLists.txt ebdd2a8 
  krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc bbfe5cd 
  krita/plugins/extensions/bigbrother/bigbrother.cc 2628c21 
  krita/plugins/extensions/bigbrother/bigbrother.rc 913dccf 
  krita/plugins/extensions/clonesarray/clonesarray.cpp 81b2fa4 
  krita/plugins/extensions/colorrange/colorrange.cc 2ea7168 
  krita/komvc/MacSupport.h PRE-CREATION 
  krita/komvc/MacSupport.mm PRE-CREATION 
  krita/komvc/Mainpage.dox PRE-CREATION 
  krita/komvc/PriorityQueue_p.h PRE-CREATION 
  krita/komvc/calligra_shell.rc PRE-CREATION 
  krita/komvc/calligradocker.desktop PRE-CREATION 
  krita/CMakeLists.txt 18ba261 
  krita/animator/CMakeLists.txt 3d532b8 
  krita/komvc/KoTemplateTree.cpp PRE-CREATION 
  krita/komvc/KoTemplates.h PRE-CREATION 
  krita/komvc/KoTemplates.cpp PRE-CREATION 
  krita/komvc/KoTemplatesPane.h PRE-CREATION 
  krita/komvc/KoTemplatesPane.cpp PRE-CREATION 
  krita/komvc/KoToolBox.cpp PRE-CREATION 
  krita/komvc/KoToolBoxDocker.cpp PRE-CREATION 
  krita/komvc/KoToolBoxDocker_p.h PRE-CREATION 
  krita/komvc/KoToolBoxFactory.h PRE-CREATION 
  krita/komvc/KoToolBoxFactory.cpp PRE-CREATION 
  krita/komvc/KoToolBoxLayout_p.h PRE-CREATION 
  krita/komvc/KoToolBox_p.h PRE-CREATION 
  krita/komvc/KoToolDocker_p.h PRE-CREATION 
  krita/komvc/KoToolDocker_p.cpp PRE-CREATION 
  krita/komvc/KoUndoStackAction.h PRE-CREATION 
  krita/komvc/KoUndoStackAction.cpp PRE-CREATION 
  krita/komvc/KoView.h PRE-CREATION 
  krita/komvc/KoView.cpp PRE-CREATION 
  krita/komvc/KoViewAdaptor.h PRE-CREATION 
  krita/komvc/KoViewAdaptor.cpp PRE-CREATION 
  krita/komvc/KoView_p.h PRE-CREATION 
  krita/komvc/KoStandardAction.cpp PRE-CREATION 
  krita/komvc/KoStartupDialog.h PRE-CREATION 
  krita/komvc/KoStartupDialog.cpp PRE-CREATION 
  krita/komvc/KoTemplate.h PRE-CREATION 
  krita/komvc/KoTemplate.cpp PRE-CREATION 
  krita/komvc/KoTemplateCreateDia.h PRE-CREATION 
  krita/komvc/KoTemplateCreateDia.cpp PRE-CREATION 
  krita/komvc/KoTemplateGroup.h PRE-CREATION 
  krita/komvc/KoTemplateGroup.cpp PRE-CREATION 
  krita/komvc/KoTemplateTree.h PRE-CREATION 
  krita/komvc/KoRuler_p.h PRE-CREATION 
  krita/komvc/KoRulerController.cpp PRE-CREATION 
  krita/komvc/KoRulerController_p.h PRE-CREATION 
  karbon/ui/KarbonView.cpp 065befa 
  karbon/ui/KarbonPrintJob.h c1cc378 
  karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.cpp 7b42dd8 
  karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.h 7b55f7c 
  karbon/plugins/tools/KarbonPatternTool.h 4abd14d 
  karbon/plugins/tools/KarbonPatternTool.cpp 9ce2a55 
  karbon/plugins/tools/KarbonGradientTool.cpp 0556e4e 
  karbon/plugins/tools/KarbonGradientTool.h 9d9b936 
  karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp 607d7f1 
  karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.h 3ca8efc 
  filters/sheets/opencalc/opencalcstyleexport.cc b5bd219 
  filters/sheets/opencalc/opencalcimport.cc d70d8fe 
  filters/sheets/opencalc/opencalcexport.cc ba38b0c 
  filters/sheets/gnumeric/gnumericimport.cc 7a013cc 
  filters/sheets/excel/import/excelimporttoods.cc 52bde7f 
  filters/sheets/excel/import/ExcelImport.cpp cc0f742 
  braindump/src/import/ToolDocker_p.h 57f3a2e 
  braindump/src/import/ToolDocker.cpp b9766de 
  braindump/src/import/ToolDocker.h 6eb8f35 
  braindump/src/import/DockerManager.h 6991668 
  braindump/src/import/DockerManager.cpp 0caf0e9 
  braindump/src/View.cpp b93994b 
  braindump/plugins/webshape/WebTool.cpp cb80f24 
  braindump/plugins/stateshape/StateTool.cpp cd352be 
  braindump/plugins/webshape/WebTool.h 7858f0d 
  braindump/plugins/stateshape/StateTool.h a7417fa 
  CMakeLists.txt f927b6e 
  krita/animator/kritaanimation.rc d607c64 
  krita/benchmarks/CMakeLists.txt 86794a5 
  krita/crashreporter/CMakeLists.txt 815f608 
  krita/gemini/kritagemini.rc f072234 
  krita/image/CMakeLists.txt cedc812 
  krita/image/TODO e046314 
  krita/image/tests/CMakeLists.txt f59466c 
  krita/image/tiles3/tests/CMakeLists.txt 802b675 
  krita/kis_splash_screen.h 2a1c7d4 
  krita/kis_splash_screen.cpp 72f6d85 
  krita/komvc/CMakeLists.txt PRE-CREATION 
  krita/komvc/KoApplication.h PRE-CREATION 
  krita/komvc/KoApplication.cpp PRE-CREATION 
  krita/komvc/KoApplicationAdaptor.h PRE-CREATION 
  krita/komvc/KoApplicationAdaptor.cpp PRE-CREATION 
  krita/komvc/KoAutoSaveRecoveryDialog.h PRE-CREATION 
  krita/komvc/KoAutoSaveRecoveryDialog.cpp PRE-CREATION 
  krita/komvc/KoDetailsPane.h PRE-CREATION 
  krita/komvc/KoDetailsPane.cpp PRE-CREATION 
  krita/komvc/KoDetailsPaneBase.ui PRE-CREATION 
  krita/komvc/KoDockerManager.h PRE-CREATION 
  krita/komvc/KoDockerManager.cpp PRE-CREATION 
  krita/komvc/KoDockerManager_p.h PRE-CREATION 
  krita/komvc/KoDocument.h PRE-CREATION 
  krita/komvc/KoDocument.cpp PRE-CREATION 
  krita/komvc/KoDocumentAdaptor.h PRE-CREATION 
  krita/komvc/KoDocumentAdaptor.cpp PRE-CREATION 
  krita/komvc/KoDocumentEntry.h PRE-CREATION 
  krita/komvc/KoDocumentEntry.cpp PRE-CREATION 
  krita/komvc/KoDocumentInfo.h PRE-CREATION 
  krita/komvc/KoDocumentInfo.cpp PRE-CREATION 
  krita/komvc/KoDocumentInfoDlg.h PRE-CREATION 
  krita/komvc/KoDocumentInfoDlg.cpp PRE-CREATION 
  krita/komvc/KoDocumentInfoPropsPage.h PRE-CREATION 
  krita/komvc/KoDocumentInfoPropsPage.cpp PRE-CREATION 
  krita/komvc/KoDocumentSectionDelegate.h PRE-CREATION 
  krita/komvc/KoDocumentSectionDelegate.cpp PRE-CREATION 
  krita/komvc/KoDocumentSectionModel.h PRE-CREATION 
  krita/komvc/KoDocumentSectionPropertyAction_p.h PRE-CREATION 
  krita/komvc/KoDocumentSectionToolTip.h PRE-CREATION 
  krita/komvc/KoDocumentSectionToolTip.cpp PRE-CREATION 
  krita/komvc/KoDocumentSectionView.h PRE-CREATION 
  krita/komvc/KoDocumentSectionView.cpp PRE-CREATION 
  krita/komvc/KoFilter.h PRE-CREATION 
  krita/komvc/KoFilter.cpp PRE-CREATION 
  krita/komvc/KoFilterChain.h PRE-CREATION 
  krita/komvc/KoFilterChain.cpp PRE-CREATION 
  krita/komvc/KoFilterChainLink.h PRE-CREATION 
  krita/komvc/KoFilterChainLink.cpp PRE-CREATION 
  krita/komvc/KoFilterChainLinkList.h PRE-CREATION 
  krita/komvc/KoFilterChainLinkList.cpp PRE-CREATION 
  krita/komvc/KoFilterEdge.h PRE-CREATION 
  krita/komvc/KoFilterEdge.cpp PRE-CREATION 
  krita/komvc/KoFilterEntry.h PRE-CREATION 
  krita/komvc/KoFilterEntry.cpp PRE-CREATION 
  krita/komvc/KoFilterGraph.h PRE-CREATION 
  krita/komvc/KoFilterGraph.cpp PRE-CREATION 
  krita/komvc/KoFilterManager.h PRE-CREATION 
  krita/komvc/KoFilterManager.cpp PRE-CREATION 
  krita/komvc/KoFilterManager_p.h PRE-CREATION 
  krita/komvc/KoFilterManager_p.cpp PRE-CREATION 
  krita/komvc/KoFilterVertex.h PRE-CREATION 
  krita/komvc/KoFilterVertex.cpp PRE-CREATION 
  krita/komvc/KoFontComboBox.h PRE-CREATION 
  krita/komvc/KoGridData.h PRE-CREATION 
  krita/komvc/KoGridData.cpp PRE-CREATION 
  krita/komvc/KoMainWindow.h PRE-CREATION 
  krita/komvc/KoMainWindow.cpp PRE-CREATION 
  krita/komvc/KoOpenPane.h PRE-CREATION 
  krita/komvc/KoOpenPane.cpp PRE-CREATION 
  krita/komvc/KoOpenPaneBase.ui PRE-CREATION 
  krita/komvc/KoPageWidgetItem.h PRE-CREATION 
  krita/komvc/KoPart.h PRE-CREATION 
  krita/komvc/KoPart.cpp PRE-CREATION 
  krita/komvc/KoPartAdaptor.h PRE-CREATION 
  krita/komvc/KoPartAdaptor.cpp PRE-CREATION 
  krita/komvc/KoPrintJob.h PRE-CREATION 
  krita/komvc/KoPrintJob.cpp PRE-CREATION 
  krita/komvc/KoStandardAction.h PRE-CREATION 
  krita/komvc/KoPrintingDialog.h PRE-CREATION 
  krita/komvc/KoPrintingDialog.cpp PRE-CREATION 
  krita/komvc/KoPrintingDialog_p.h PRE-CREATION 
  krita/komvc/KoRecentDocumentsPane.h PRE-CREATION 
  krita/komvc/KoRecentDocumentsPane.cpp PRE-CREATION 
  krita/komvc/KoRuler.h PRE-CREATION 
  krita/komvc/KoRuler.cpp PRE-CREATION 
  krita/komvc/KoRulerController.h PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119612/diff/


Testing
-------

Crash when: 
* opening a new document after closing one

Broken connnections:

Object::connect: No such slot KisCanvasController::resetCanvasTransformations() in /home/boud/kde/src/calligra/krita/ui/kis_view2.cpp:473
Object::connect:  (sender name:   'reset_canvas_transformations')

Broken guides:

krita(28323)/koffice (lib komain) KoRuler::createGuideToolConnection: No guides tool found, skipping connection

xmlgui error:

krita(28323)/kdeui (kdelibs) KXMLGUIClient::~KXMLGUIClient: 0x5f5ad48 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.


File Attachments
----------------

Krita with two files open in tabs
  https://git.reviewboard.kde.org/media/uploaded/files/2014/08/05/b75a3861-20fc-49e2-9cc2-eb20598f8e20__komvc.png


Thanks,

Boudewijn Rempt

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141015/0f8d6c1c/attachment.htm>


More information about the calligra-devel mailing list