Review Request 120545: Use pg_type.h from postgresql server includes

Jarosław Staniek staniek at kde.org
Sat Oct 11 18:22:57 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120545/
-----------------------------------------------------------

(Updated Oct. 11, 2014, 7:22 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.


Repository: calligra


Description
-------

Kexi had a copy of pg_type.h from somewhere. This is always dangerous.
To find proper pg_type.h we need to override system FindPostgreSQL.cmake
(kdelibs' one is outdated, and even the one from cmake 3 isn't sufficient).

So a copy from current libPredicate is used.

(Kexi 3 will not use this workaround, but depend on what Predicate finds)


Diffs
-----

  kexi/migration/pqxx/pg_type.h e36435690a3812b751d8fc554f041af729eac0d8 
  kexi/migration/pqxx/pqxxmigrate.cpp 47c036a2506ad5a3841756a998d60b242e316dd7 
  kexi/kexidb/drivers/pqxx/CMakeLists.txt d8e92e5962bcb2bae702d5c143ec68972622eb4d 
  kexi/kexidb/drivers/pqxx/pqxxcursor.h 7af911ef2d68801ae6eb6e8371f3c9a3645fab1a 
  kexi/migration/pqxx/CMakeLists.txt 6fe14a0d1fe05384517ce43aa80c8f41f4e4487b 
  cmake/modules/FindCalligraPostgreSQL.cmake PRE-CREATION 
  kexi/CMakeLists.txt 55d5e43d01b960cabc41a098bbdf8e53964c91e3 

Diff: https://git.reviewboard.kde.org/r/120545/diff/


Testing
-------

Master builds and runs


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141011/7b3bf4ae/attachment.htm>


More information about the calligra-devel mailing list