Review Request 120547: krita: save text tool options

[Scott Petrovic]

> On Oct. 10, 2014, 9:28 p.m., Sven Langkamp wrote:
> > krita/plugins/tools/tool_text/kis_tool_text.cc, line 156
> > <https://git.reviewboard.kde.org/r/120547/diff/1/?file=317597#file317597line156>
> >
> >     This could be added to the destructor and it would not need separate methods.

I discussed this with Sven a bit on IRC. I tried moving the config.WriteEntry() code into the deconstructor, but that is creating a segmentation fault error. If you close Krita when you are on the tool, the KConfig object must be getting destroyed before the tool is being destroyed. I also tried defining the config object in the constructor, but that gave errors as well, so the definition was placed in activate()


- Scott


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120547/#review68237
-----------------------------------------------------------


On Oct. 10, 2014, 3:09 a.m., Scott Petrovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120547/
> -----------------------------------------------------------
> 
> (Updated Oct. 10, 2014, 3:09 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> save tool options to kritarc. 
> 
> 
> Diffs
> -----
> 
>   krita/plugins/tools/tool_text/kis_text_tool_option_widget.h fa9277b 
>   krita/plugins/tools/tool_text/kis_text_tool_option_widget.cpp e017414 
>   krita/plugins/tools/tool_text/kis_tool_text.h 15b486e 
>   krita/plugins/tools/tool_text/kis_tool_text.cc 96f89bc 
> 
> Diff: https://git.reviewboard.kde.org/r/120547/diff/
> 
> 
> Testing
> -------
> 
> Watched the kritarc file update as I changed settings.
> 
> 
> Thanks,
> 
> Scott Petrovic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141011/0fc75202/attachment.htm>