Review Request 120468: Check cell size constraints before aborting layout

[Pierre Ducroquet]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120468/
-----------------------------------------------------------

(Updated Oct. 3, 2014, 5:34 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra and Camilla Boemann.


Bugs: 293337
    http://bugs.kde.org/show_bug.cgi?id=293337


Repository: calligra


Description
-------

Check cell size constraints regarding requested row height to prevent infinite looking for space.
When fixed row height < padding + borders, things go really bad : we are starving for space, but we can never get past this demand.
My current solution is to acknowledge that we are in an impossible situation and, instead of asking for space, layout knowing that nothing fits in there.


Diffs
-----

  libs/textlayout/KoTextLayoutTableArea.cpp 4fbec7b3b0a0e4b92a2bbbd925491b084e80748a 

Diff: https://git.reviewboard.kde.org/r/120468/diff/


Testing
-------

Document from bug report 293337 is now working, so both regular tables and weird too-small cells work.


Thanks,

Pierre Ducroquet

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141003/c293be00/attachment.htm>