Review Request 106283: Add Blob Tool to Calligra

[José Luis Vergara]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/106283/
-----------------------------------------------------------

(Updated Oct. 2, 2014, 4:17 p.m.)


Status
------

This change has been discarded.


Review request for Calligra, Camilla Boemann, Inge Wallin, Sven Langkamp, and Boudewijn Rempt.


Repository: calligra


Description
-------

Blob tool is the name for a vector brush that creates a broad stroke that fuses with itself and with other shapes that have the same styling, thus helping to create more organic-looking vector images.
This patch implements a very basic version of this tool, missing the ability to fuse shapes with other shapes, which I am postponing until we fix bug 297623 (see thread http://mail.kde.org/pipermail/calligra-devel/2012-August/006633.html ).
Further details and a link to a video in blog  http://pentalis.org/kritablog/?p=315

Note: some dependencies (like KarbonCurveFit) need to be moved, I will post a separate review for that, because I need to discuss what directory it belongs to.

I need an easy way to make clear I commit my code in either license, LGPL, GPL, or anything we need for it to fit well in our project; it's not easy to convey since files accumulate more contributors the more time passes by. Suggestions appreciated.


Diffs
-----

  plugins/CMakeLists.txt 526499f 
  plugins/vectortools/CMakeLists.txt PRE-CREATION 
  plugins/vectortools/KoBlobTool.h PRE-CREATION 
  plugins/vectortools/KoBlobTool.cpp PRE-CREATION 
  plugins/vectortools/KoBlobToolFactory.h PRE-CREATION 
  plugins/vectortools/KoBlobToolFactory.cpp PRE-CREATION 
  plugins/vectortools/KoVectorToolsPlugin.h PRE-CREATION 
  plugins/vectortools/KoVectorToolsPlugin.cpp PRE-CREATION 
  plugins/vectortools/calligravectortools.desktop PRE-CREATION 
  plugins/vectortools/hi22-action-blob-tool.png PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/106283/diff/


Testing
-------

Tested compilation, loading in applications Karbon and Krita, and basic functioning of the tool. It works (incompletely) as intended for a small group of use cases. Also tested speed, it needs to be faster, but is usable.


Thanks,

José Luis Vergara

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141002/9b56ceb3/attachment.htm>