Review Request 120348: Krita: Add unit of measurement to brush size and remove precision

Scott Petrovic scottpetrovic at gmail.com
Thu Oct 2 00:46:02 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120348/
-----------------------------------------------------------

(Updated Oct. 1, 2014, 11:46 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra.


Repository: calligra


Description
-------

It is helpful when numbers have a context for them (ie px). I am also not sure how valuable values like 45.24 are with brush sizes. I think not using floats is easier to read and has little impact on painting.


Diffs
-----

  krita/plugins/paintops/libpaintop/kis_auto_brush_widget.cpp 42ffe23 
  krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp 3bd7aa6 
  krita/ui/kis_paintop_box.cc 9a22571 

Diff: https://git.reviewboard.kde.org/r/120348/diff/


Testing
-------


Thanks,

Scott Petrovic

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141001/7e860989/attachment.htm>


More information about the calligra-devel mailing list