Review Request 120347: Krita: Add degree symbol for rotation property and remove precision

[Boudewijn Rempt]

> On Sept. 25, 2014, 11:42 a.m., Boudewijn Rempt wrote:
> > Hm, I'm all for the symbol. I'm not sure whether it's a good idea to remove precision here -- it's something to discuss with artists.
> 
> Scott Petrovic wrote:
>     I sent out a question in the forum, but haven't received any responses. https://forum.kde.org/viewtopic.php?f=137&t=123032&sid=43955212b3430e9a50e51d7473008d3d ( has about 50 views) My guess is that no one cares enough to make a comment. :). 
>     
>     The last bit of push I will give is that angle is also set in the brush editor > brush tip > auto. That has the degree symbol and no floating point precision. You can make the call. 
>     
>     Also for the "shipped" bugs, am I supposed to be pushing these to master since I have a developer account. I would think so, but wanted to double check.

Okay, let's go for consistency and no floats then :-) And yes, please push the reviews that have a ship-it to master!


- Boudewijn


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120347/#review67414
-----------------------------------------------------------


On Sept. 24, 2014, 3:04 a.m., Scott Petrovic wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120347/
> -----------------------------------------------------------
> 
> (Updated Sept. 24, 2014, 3:04 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> I think this is easier to understand and read for a rotation property. I don't know if people really need floating precision for angles too.
> 
> 
> Diffs
> -----
> 
>   krita/plugins/paintops/libpaintop/kis_brush_chooser.cpp f4fd873 
> 
> Diff: https://git.reviewboard.kde.org/r/120347/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Scott Petrovic
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141001/ccf9ca1d/attachment.htm>