Review Request 121226: Krita - Clean global origin workaround

[Damien de Lemeny]

> On nov. 24, 2014, 10:13 matin, Dmitry Kazakov wrote:
> > If the tablet still works correctly, then I'm ok with pushing it into master
> 
> Boudewijn Rempt wrote:
>     Dmitry, had you already pushed this? Or... Damien -- have you asked for a committer account?

I didn't see it pushed yet. My KDE developer acount has been activated last night, I propose to just wait for you to merge MVC in master : I'll test my patch against it and commit then.


- Damien


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121226/#review70844
-----------------------------------------------------------


On nov. 23, 2014, 9:23 après-midi, Damien de Lemeny wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121226/
> -----------------------------------------------------------
> 
> (Updated nov. 23, 2014, 9:23 après-midi)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> KisToolProxy::forwardEvent had an ugly workaround parameter to get the origin coordinates of the canvas converted to global coordinates. Better have KisToolProxy creating that origin instead of passing it around.
> 
> 
> Diffs
> -----
> 
>   krita/ui/canvas/kis_tool_proxy.h 307e627 
>   krita/ui/canvas/kis_tool_proxy.cpp 0545ea0 
>   krita/ui/input/kis_alternate_invocation_action.cpp ce61a84 
>   krita/ui/input/kis_change_primary_setting_action.cpp aeade2c 
>   krita/ui/input/kis_input_manager.cpp 89919dc 
>   krita/ui/input/kis_tool_invocation_action.cpp 33e2640 
> 
> Diff: https://git.reviewboard.kde.org/r/121226/diff/
> 
> 
> Testing
> -------
> 
> Compiles OK
> Primary tool invocation OK
> Alternate tool invocation OK
> Change primary settings OK
> 
> 
> Thanks,
> 
> Damien de Lemeny
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141125/40ad8b61/attachment.htm>