Review Request 121156: Simplify "Save password" checkbox text but add direct what's this button

Friedrich W. H. Kossebau kossebau at kde.org
Tue Nov 25 00:04:19 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121156/#review70883
-----------------------------------------------------------

Ship it!


Interesting idea with the What's this button, can imagine that this improves things for users. Seems good to me to go in.

Is it following some UI pattern? Ideally something that will be consistenly solved in other apps as well?

- Friedrich W. H. Kossebau


On Nov. 17, 2014, 6:42 nachm., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121156/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2014, 6:42 nachm.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Simplify "Save password" checkbox text but add direct what's this button
> 
> + improve layout and tab order
> 
> 
> Diffs
> -----
> 
>   kexi/widget/kexidbconnectionwidget.h 14e49004d87a2977616fe869d2f0ea0b2c545bc1 
>   kexi/widget/kexidbconnectionwidget.cpp 5345beabc28591dec918d8212bb494166e970ac2 
>   kexi/widget/kexidbconnectionwidget.ui f78f27ef9ce70cfaf626188a89bcf9b8a971d42b 
> 
> Diff: https://git.reviewboard.kde.org/r/121156/diff/
> 
> 
> Testing
> -------
> 
> Dialog improved, overall features the same
> 
> 
> File Attachments
> ----------------
> 
> The dialog with the What's This box
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/11/17/e666191e-2f5c-4d2b-ae45-45b5fc34c4d7__savepwd.png
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141125/66f02723/attachment.htm>


More information about the calligra-devel mailing list