Review Request 121174: Fix checking for file overwriting on file creation

[Roman Shtemberko]

> On Ноя. 20, 2014, 2:37 п.п., Roman Shtemberko wrote:
> > Ship It!

Works nice.


- Roman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121174/#review70691
-----------------------------------------------------------


On Ноя. 19, 2014, 12:52 д.п., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121174/
> -----------------------------------------------------------
> 
> (Updated Ноя. 19, 2014, 12:52 д.п.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Friedrich W. H. Kossebau, Adam Pigg, Roman Shtemberko, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix checking for file overwriting on file creation
> 
> Startup file handler: update filename after adding extension,
> otherwise checking for overwriting isn't accurate.
> 
> Example of inaccurate behaviour:
> User enters /tmp/a and /tmp/a does not exist.
> Kexi changes it to /tmp/a.kexi but still checks if /tmp/a exists.
> If /tmp/a.kexi exists, user won't be notified and asked.
> 
> In addition the handler now checks if user entered existing
> directory path without filename; if so, it warns about that.
> This avoids creating nonsense ".kexi" files (that look like hidden).
> 
> The fix works for CSV creation too.
> 
> 
> Diffs
> -----
> 
>   kexi/main/startup/KexiStartupFileHandler.cpp ff483e7 
>   kexi/main/startup/KexiStartupFileHandler.h d203bb4 
>   kexi/main/startup/KexiNewProjectAssistant.cpp 633d919 
> 
> Diff: https://git.reviewboard.kde.org/r/121174/diff/
> 
> 
> Testing
> -------
> 
> Creation works as before
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141120/1f40ee8a/attachment.htm>