Review Request 121126: Krita: add size constraints to certain selection and shape tools

Jouni Pentikäinen mctyyppi42 at gmail.com
Fri Nov 14 19:47:35 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121126/
-----------------------------------------------------------

Review request for Calligra.


Repository: calligra


Description
-------

Added width, height and aspect ratio constraints to rectangular and elliptical selection and shape tools. The constraints can be activated under the tool options. 

This also extends shift behavior. If no constraints are applied, shift forces square ratio as before. If there are constraints, shift disables them reverting to normal behavior.

Alt and ctrl work as before, as allowed by active constraints.


Diffs
-----

  krita/ui/CMakeLists.txt f93803e 
  krita/ui/forms/wdgrectangleconstraints.ui PRE-CREATION 
  krita/ui/tool/kis_rectangle_constraint_widget.h PRE-CREATION 
  krita/ui/tool/kis_rectangle_constraint_widget.cpp PRE-CREATION 
  krita/ui/tool/kis_tool_rectangle_base.h ead8cf5 
  krita/ui/tool/kis_tool_rectangle_base.cpp e6c9b89 

Diff: https://git.reviewboard.kde.org/r/121126/diff/


Testing
-------

All affected tools seem to work as expected.

Tested all (hopefully) combinations of modifier keys and constraints on rectangular selections. Working as described.


Thanks,

Jouni Pentikäinen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141114/a65160d4/attachment.htm>


More information about the calligra-devel mailing list