Review Request 119612: Implement an MDI interface for Krita
Boudewijn Rempt
boud at valdyas.org
Fri Nov 14 09:51:55 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119612/
-----------------------------------------------------------
(Updated Nov. 14, 2014, 9:51 a.m.)
Review request for Calligra.
Changes
-------
Fixed most of the issues in https://docs.google.com/spreadsheets/d/1UygDYZn4Wg6HQSYGOfaGAUGkDMs8NDougYDHlkROoZQ/edit#gid=0.
Still broken are:
* LUT docker
* Assistants
* Sketch
* Gemini
For the rest, it's getting pretty close to mainline usability.
Repository: calligra
Description
-------
As discussed at the calligra sprint, this isn't a full port of all of Calligra to MDI. This patch contains a stripped copy of komain, renamed to komvc and made local for Krita. It also doesn't contain the stripped fork of KXMLGui, though I still intend to make Krita independent of KXMLGui in time for the KF5 port. There is one global change and that puts the tool option widgets list for the toolbox in a QPointer.
In Krita, KisView is split into KisMainWindow, KisView and KisImageView. An image can be shown in more than one view, more than one view can be shown in a mainwindow, and more than one mainwindow can be open.
KisPart2 inherits KoPart and keeps the list of views, documents and mainwindows.
KisMainWindow is the mainwindow, inheriting KoMainWindow. It it responsible for managing the list of subwindows in, currently, a QMdiArea set to tabbed mode by default.
KisView2 is a pure KXMLGuiClient that adds actions and so on to KoMainWindow. It still has a lot of pass-through methods because all of Krita queries KisView2 for things like the active document, image, node, selection etc.
KisImageView is a view on a single image. It owns a canvas widget and manages zoom levels.
Problems:
* I had to disable sketch and gemini because I haven't yet been able to figure out how to port those applications to the KisImageView/KisView split. Especially, should the sync event handling be in KisMainWindow or KisImageView?
* XXX: KOMVC marks places where code has been commented out, mostly to do with canvas decorations like assistants and color management.
* Changes are as minimal as possible, so no cleanup yet of documentation, coding style and so on.
* There still are quite a few bugs that need fixing.
* Krita doesn't actually start with this version...
Diffs (updated)
-----
plugins/defaultTools/connectionTool/ConnectionTool.cpp 79088e4
plugins/defaultTools/defaulttool/DefaultTool.h dca6ae8
plugins/defaultTools/defaulttool/DefaultTool.cpp 7304fb2
plugins/defaultTools/guidestool/GuidesTool.h 5a74b12
plugins/defaultTools/guidestool/GuidesTool.cpp ffa2fa5
plugins/dockers/shapeproperties/ShapePropertiesDocker.h 99c075c
plugins/dockers/snapguidedocker/SnapGuideDocker.h 8fbd45d
plugins/textshape/CMakeLists.txt bebe11a
plugins/textshape/ReferencesTool.h 02d8c51
plugins/textshape/ReferencesTool.cpp be7f558
plugins/textshape/ReviewTool.h 66e0e9d
plugins/textshape/ReviewTool.cpp 9bee633
plugins/textshape/TextDocumentInspectionDocker.h c0ff123
plugins/textshape/TextTool.h 5e01e02
krita/ui/wdgsplash.ui PRE-CREATION
krita/ui/widgets/KisFlipbookSelector.h 31af828
krita/ui/widgets/KisFlipbookSelector.cpp c78488f
krita/ui/widgets/kis_animation_selector.h 9afac63
krita/ui/widgets/kis_animation_selector.cpp 08c9372
krita/ui/widgets/kis_custom_image_widget.h 678925c
krita/ui/widgets/kis_custom_image_widget.cc fff0df2
krita/ui/widgets/kis_image_from_clipboard_widget.h 3b8b2bb
krita/ui/widgets/kis_image_from_clipboard_widget.cpp 422740d
krita/ui/widgets/kis_progress_widget.h 9f77df4
krita/ui/widgets/kis_scratch_pad.cpp 6c85e67
krita/wdgsplash.ui bf6a9eb
libs/CMakeLists.txt f4f232a
libs/basicflakes/tools/KoCreatePathTool.h a14bd07
libs/basicflakes/tools/KoCreatePathTool.cpp 3f454fd
libs/basicflakes/tools/KoPencilTool.h 1c32ed8
libs/basicflakes/tools/KoPencilTool.cpp 264b5db
libs/flake/KoCanvasBase.h 243003b
libs/flake/KoCanvasBase.cpp 4949402
libs/flake/KoCanvasController.h 804a1e4
libs/flake/KoCanvasControllerWidget.h a822ad6
libs/flake/KoCanvasControllerWidget.cpp fa3eaa6
libs/flake/KoCanvasControllerWidget_p.h 0a6c298
libs/flake/KoCanvasObserverBase.h 6750e02
libs/flake/KoToolBase.h 18faa58
libs/flake/KoToolBase.cpp 963dfad
libs/flake/KoToolBase_p.h f79e556
libs/flake/KoToolManager.cpp 5d4da91
libs/flake/tools/KoPathTool.h 6577f76
libs/flake/tools/KoPathTool.cpp c475876
libs/kopageapp/KoPAPrintJob.h e6762a1
libs/kopageapp/KoPAView.cpp 6e0b519
libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.h e55c0bb
libs/kopageapp/tools/backgroundTool/KoPABackgroundTool.cpp 2b155fb
libs/koproperty/editors/combobox.cpp 26a2ec3
libs/kotext/CMakeLists.txt 3931224
libs/main/CMakeLists.txt b1693fd
libs/main/KoDockerManager.h f465edf
libs/main/KoDockerManager.cpp ec93c7c
libs/main/KoGlobal.h 89f5429
libs/main/KoGlobal.cpp 80c3b2e
libs/main/KoMainWindow.cpp 8db43f8
libs/main/KoModeBox.cpp 57c64cc
libs/main/KoModeBoxDocker_p.h 4d1e6e1
libs/main/KoModeBox_p.h 2f0d882
libs/main/KoToolDocker_p.h 35037d0
libs/main/KoToolDocker_p.cpp 9039f40
libs/main/KoView.cpp 4770dcc
libs/main/thememanager.h c179126
libs/main/thememanager.cpp 4ff9022
libs/main/thememanager.rc 2b487a2
libs/widgets/CMakeLists.txt 433071d
libs/widgets/KoGlobal.h PRE-CREATION
libs/widgets/KoGlobal.cpp PRE-CREATION
libs/widgets/KoZoomAction.cpp 45269f9
plugins/artistictextshape/ArtisticTextTool.h 748300f
plugins/artistictextshape/ArtisticTextTool.cpp 48f40b1
plugins/defaultTools/connectionTool/ConnectionTool.h 4abb560
krita/ui/tests/kis_flipbook_test.cpp df951f1
krita/ui/tests/kis_kra_loader_test.cpp d5b9012
krita/ui/tests/kis_action_manager_test.cpp bd3171f
krita/ui/tests/kis_doc2_test.cpp 4d193b6
krita/ui/operations/kis_operation_ui_widget_factory.h 8821d82
krita/ui/recorder/kis_recorded_paint_action_editor.cc c893035
krita/ui/tests/CMakeLists.txt a5c3301
krita/ui/tests/fill_processing_visitor_test.cpp 1d3993c
krita/ui/kis_zoom_manager.cc 8489f07
krita/ui/kranim/kis_kranim_saver.cpp 1ba0a16
krita/ui/kranimstore/kis_animation_store.cpp 92ce1bc
krita/ui/kis_selection_decoration.cc 8ec9e03
krita/ui/kis_selection_manager.h 3e2f5bb
krita/ui/kis_selection_manager.cc e3518df
krita/ui/kis_splash_screen.h PRE-CREATION
krita/ui/kis_splash_screen.cpp PRE-CREATION
krita/ui/kis_statusbar.h 5b5c74e
krita/ui/kis_statusbar.cc f56eae0
krita/ui/kis_tooltip_manager.cpp ea0f377
krita/ui/kis_view2.h ebdfc5e
krita/ui/kis_view2.cpp aa894e8
krita/ui/kis_zoom_manager.h a4ea1a6
krita/ui/kis_print_job.h 387d64b
krita/ui/kis_safe_document_loader.cpp 1fefdb1
krita/ui/kis_selection_decoration.h b29733a
krita/ui/kis_paintop_box.h 70ada82
krita/ui/kis_paintop_box.cc 29f1773
krita/ui/kis_part2.h ef9eba8
krita/ui/kis_part2.cpp 98ff39b
krita/ui/kis_painting_assistants_manager.cpp PRE-CREATION
krita/ui/kis_mirror_axis.cpp 0251bca
krita/ui/kis_node_manager.h de578be
krita/ui/kis_node_manager.cpp b87a415
krita/ui/kis_flipbook_item.cpp 60501d1
krita/ui/kis_image_manager.h bafe9f3
krita/ui/kis_image_manager.cc 2d7ae64
krita/ui/kis_image_view.h PRE-CREATION
krita/ui/kis_image_view.cpp PRE-CREATION
krita/ui/kis_import_catcher.cc c88b0ab
krita/ui/kis_layer_manager.h b0f5984
krita/ui/kis_layer_manager.cc 9032725
krita/ui/kis_main_window.h PRE-CREATION
krita/ui/kis_main_window.cpp PRE-CREATION
krita/ui/kis_mainwindow_observer.h PRE-CREATION
krita/ui/kis_mainwindow_observer.cpp PRE-CREATION
krita/ui/kis_mask_manager.h 9e8abec
krita/ui/kis_mask_manager.cc f03bd80
krita/ui/kis_mimedata.cpp 18a3d80
krita/ui/kis_mirror_axis.h 36d4d89
krita/ui/kis_aboutdata.h 06f7438
krita/ui/kis_aboutdata.cpp PRE-CREATION
krita/ui/kis_action.h 18cca90
krita/ui/kis_action.cpp dd143de
krita/ui/kis_action_manager.h ab7816f
krita/ui/kis_action_manager.cpp 4562d41
krita/ui/kis_animation.h 591b761
krita/ui/kis_animation.cpp c65a222
krita/ui/kis_animation_doc.h c5c4ab6
krita/ui/kis_animation_doc.cpp b0518d9
krita/ui/kis_animation_factory.h 42d87cb
krita/ui/kis_animation_factory.cpp eeb770b
krita/ui/kis_animation_frame.h PRE-CREATION
krita/ui/kis_animation_frame.cpp PRE-CREATION
krita/ui/kis_animation_layer.h PRE-CREATION
krita/ui/kis_animation_layer.cpp PRE-CREATION
krita/ui/kis_animation_model.h PRE-CREATION
krita/ui/kis_animation_model.cpp PRE-CREATION
krita/ui/kis_animation_part.h 03cad7d
krita/ui/kis_animation_part.cpp f8e9d35
krita/ui/kis_animation_player.h 47adcbb
krita/ui/kis_animation_player.cpp 979bf1d
krita/ui/kis_canvas_controls_manager.h 5f514e7
krita/ui/kis_canvas_controls_manager.cpp 38280bf
krita/ui/kis_canvas_resource_provider.h b72de92
krita/ui/kis_config.h 357a9ee
krita/ui/kis_config.cc 09d7d6a
krita/ui/kis_control_frame.h 5a379ab
krita/ui/kis_control_frame.cpp 1206df7
krita/ui/kis_doc2.h e4be839
krita/ui/kis_doc2.cc 74a86ad
krita/ui/kis_factory2.cc 4499da2
krita/ui/kis_filter_manager.h 666403f
krita/ui/kis_filter_manager.cc 46215af
krita/ui/kis_flipbook.h cd1ce19
krita/ui/kis_flipbook.cpp ec3eefe
krita/ui/kis_onion_skin_loader.h c346474
krita/ui/kis_onion_skin_loader.cpp 27b66c2
krita/ui/kis_painting_assistants_decoration.h 216276b
krita/ui/kis_painting_assistants_decoration.cpp 9fede84
krita/ui/kis_painting_assistants_manager.h PRE-CREATION
krita/ui/forms/wdgnewimage.ui 24839c9
krita/ui/input/kis_input_manager.cpp 89919dc
krita/ui/dialogs/kis_about_application.h PRE-CREATION
krita/ui/dialogs/kis_about_application.cpp PRE-CREATION
krita/ui/dialogs/kis_dlg_adjustment_layer.h 7da0215
krita/ui/dialogs/kis_dlg_adjustment_layer.cc 85ea267
krita/ui/dialogs/kis_dlg_filter.h 7237a3f
krita/ui/dialogs/kis_dlg_filter.cpp fcb4817
krita/ui/dialogs/kis_dlg_generator_layer.h faaf305
krita/ui/dialogs/kis_dlg_generator_layer.cpp 64adb43
krita/ui/dialogs/kis_dlg_preferences.h a40b1f2
krita/ui/dialogs/kis_dlg_preferences.cc 21d7f19
krita/ui/flake/kis_dummies_facade_base.cpp 3d3694a
krita/ui/flake/kis_shape_controller.h 39ae1eb
krita/ui/flake/kis_shape_controller.cpp a0db22d
krita/ui/forms/wdggeneralsettings.ui 50a170b
krita/ui/tests/kis_kra_saver_test.cpp 8f7876e
krita/ui/tests/kis_node_model_test.cpp 9da7fb5
krita/ui/tests/kis_shape_controller_test.cpp 63f8c4e
krita/ui/tests/kis_zoom_and_pan_test.cpp bc5b9ef
krita/ui/tests/util.h 8badb2c
krita/ui/tool/kis_delegated_tool.h c63c6f9
krita/ui/tool/kis_figure_painting_tool_helper.h cf71d02
krita/ui/tool/kis_figure_painting_tool_helper.cpp 3464420
krita/ui/tool/kis_resources_snapshot.h 95fd8a4
krita/ui/tool/kis_resources_snapshot.cpp 94ed724
krita/ui/tool/kis_tool.cc e780ee5
krita/ui/tool/kis_tool_freehand.h 1cadcde
krita/ui/tool/kis_tool_freehand.cc c706aa4
krita/ui/tool/kis_tool_freehand_helper.h 3ab5701
krita/ui/tool/kis_tool_freehand_helper.cpp 26d4ccb
krita/ui/tool/kis_tool_paint.cc b43b225
krita/ui/tool/kis_tool_polyline_base.cpp 100c2df
krita/ui/tool/kis_tool_shape.cc ab4f4a1
krita/plugins/extensions/dockers/animator/kis_animation_layerbox.h 5a6ef47
krita/plugins/extensions/dockers/animator/kis_animation_layerbox.cpp 175eceb
krita/plugins/extensions/dockers/animator/kis_frame_box.h fedc93a
krita/plugins/extensions/dockers/animator/kis_frame_box.cpp 2459787
krita/plugins/extensions/dockers/animator/kis_layer_contents.h e59f700
krita/plugins/extensions/dockers/animator/kis_layer_contents.cpp cab47a4
krita/plugins/extensions/dockers/animator/kis_opacity_selector.cpp 46964fe
krita/plugins/extensions/dockers/animator/kis_timeline.h ad0b473
krita/plugins/extensions/dockers/animator/kis_animation_layer.h 9f64f52
krita/plugins/extensions/dockers/animator/kis_animation_layer.cpp 477da4b
krita/plugins/extensions/dockers/animator/kis_animation_layer_widget.h PRE-CREATION
krita/plugins/extensions/dockers/animator/kis_animation_layer_widget.cpp PRE-CREATION
krita/plugins/extensions/dockers/animator/animator_dock.cpp 7f6e4c4
krita/plugins/extensions/dockers/animator/animator_playback_dialog.h f947c86
krita/plugins/extensions/dockers/animator/kis_animation_frame.h 493e93f
krita/plugins/extensions/dockers/animator/kis_animation_frame.cpp b130eb9
krita/plugins/extensions/dockers/animator/kis_animation_frame_widget.h PRE-CREATION
krita/plugins/extensions/dockers/animator/kis_animation_frame_widget.cpp PRE-CREATION
krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_ng_dock.h bdaa5b9
krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_ng_docker_widget.cpp 70c5757
krita/plugins/extensions/dockers/animator/CMakeLists.txt 6d80713
krita/plugins/extensions/dockers/animator/TimelineItemDelegate.h PRE-CREATION
krita/plugins/extensions/dockers/animator/TimelineItemDelegate.cpp PRE-CREATION
krita/plugins/extensions/dockers/animator/TimelineView.h PRE-CREATION
krita/plugins/extensions/dockers/animator/TimelineView.cpp PRE-CREATION
krita/plugins/extensions/dockers/animator/animator.h bab1d8d
krita/plugins/extensions/dockers/animator/animator.cpp 0f6d24c
krita/plugins/extensions/dockers/animator/animator_dock.h 2a2bc48
krita/plugins/extensions/clonesarray/clonesarray.cpp 81b2fa4
krita/plugins/extensions/colorrange/colorrange.cc 2ea7168
krita/plugins/extensions/colorspaceconversion/colorspaceconversion.cc 3386add
krita/plugins/extensions/dockers/advancedcolorselector/kis_color_history.cpp 0deeb96
krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_base.cpp 6d5adeb
krita/komvc/thememanager.h PRE-CREATION
krita/komvc/thememanager.cpp PRE-CREATION
krita/komvc/thememanager.rc PRE-CREATION
krita/krita.desktop 862b935
krita/krita.rc edd76fd
krita/libbrush/tests/CMakeLists.txt ebdd2a8
krita/plugins/assistants/RulerAssistant/kis_ruler_assistant_tool.cc 56ad0f6
krita/plugins/extensions/bigbrother/bigbrother.cc 2628c21
krita/plugins/extensions/bigbrother/bigbrother.rc 913dccf
krita/komvc/MacSupport.h PRE-CREATION
krita/komvc/MacSupport.mm PRE-CREATION
krita/komvc/Mainpage.dox PRE-CREATION
krita/komvc/PriorityQueue_p.h PRE-CREATION
krita/komvc/calligra_shell.rc PRE-CREATION
krita/komvc/calligradocker.desktop PRE-CREATION
krita/komvc/calligragitversion.h.cmake PRE-CREATION
krita/komvc/calligraversion.cpp PRE-CREATION
krita/komvc/calligraversion.h.cmake PRE-CREATION
krita/komvc/koDocumentInfoAboutWidget.ui PRE-CREATION
krita/komvc/koDocumentInfoAuthorWidget.ui PRE-CREATION
krita/komvc/komvc_export.h PRE-CREATION
krita/komvc/osx.stylesheet PRE-CREATION
krita/komvc/KoToolBoxLayout_p.h PRE-CREATION
krita/komvc/KoToolBox_p.h PRE-CREATION
krita/komvc/KoToolDocker_p.h PRE-CREATION
krita/komvc/KoToolDocker_p.cpp PRE-CREATION
krita/komvc/KoUndoStackAction.h PRE-CREATION
krita/komvc/KoUndoStackAction.cpp PRE-CREATION
krita/komvc/KoView.h PRE-CREATION
krita/komvc/KoView.cpp PRE-CREATION
krita/komvc/KoViewAdaptor.h PRE-CREATION
krita/komvc/KoViewAdaptor.cpp PRE-CREATION
krita/komvc/KoView_p.h PRE-CREATION
krita/komvc/KoTemplateCreateDia.cpp PRE-CREATION
krita/komvc/KoTemplateGroup.h PRE-CREATION
krita/komvc/KoTemplateGroup.cpp PRE-CREATION
krita/komvc/KoTemplateTree.h PRE-CREATION
krita/komvc/KoTemplateTree.cpp PRE-CREATION
krita/komvc/KoTemplates.h PRE-CREATION
krita/komvc/KoTemplates.cpp PRE-CREATION
krita/komvc/KoTemplatesPane.h PRE-CREATION
krita/komvc/KoTemplatesPane.cpp PRE-CREATION
krita/komvc/KoToolBox.cpp PRE-CREATION
krita/komvc/KoToolBoxDocker.cpp PRE-CREATION
krita/komvc/KoToolBoxDocker_p.h PRE-CREATION
krita/komvc/KoToolBoxFactory.h PRE-CREATION
krita/komvc/KoToolBoxFactory.cpp PRE-CREATION
krita/komvc/KoRuler.h PRE-CREATION
krita/komvc/KoRuler.cpp PRE-CREATION
krita/komvc/KoRulerController.h PRE-CREATION
krita/komvc/KoRulerController.cpp PRE-CREATION
krita/komvc/KoRulerController_p.h PRE-CREATION
krita/komvc/KoRuler_p.h PRE-CREATION
krita/komvc/KoStandardAction.h PRE-CREATION
krita/komvc/KoStandardAction.cpp PRE-CREATION
krita/komvc/KoStartupDialog.h PRE-CREATION
krita/komvc/KoStartupDialog.cpp PRE-CREATION
krita/komvc/KoTemplate.h PRE-CREATION
krita/komvc/KoTemplate.cpp PRE-CREATION
krita/komvc/KoTemplateCreateDia.h PRE-CREATION
krita/komvc/KoPart.cpp PRE-CREATION
krita/komvc/KoPartAdaptor.h PRE-CREATION
krita/komvc/KoPartAdaptor.cpp PRE-CREATION
krita/komvc/KoPrintJob.h PRE-CREATION
krita/komvc/KoPrintJob.cpp PRE-CREATION
krita/komvc/KoPrintingDialog.h PRE-CREATION
krita/komvc/KoPrintingDialog.cpp PRE-CREATION
krita/komvc/KoPrintingDialog_p.h PRE-CREATION
krita/komvc/KoRecentDocumentsPane.h PRE-CREATION
krita/komvc/KoRecentDocumentsPane.cpp PRE-CREATION
krita/komvc/KoFilterManager.h PRE-CREATION
krita/komvc/KoFilterManager.cpp PRE-CREATION
krita/komvc/KoFilterManager_p.h PRE-CREATION
krita/komvc/KoFilterManager_p.cpp PRE-CREATION
krita/komvc/KoFilterVertex.h PRE-CREATION
krita/komvc/KoFilterVertex.cpp PRE-CREATION
krita/komvc/KoFontComboBox.h PRE-CREATION
krita/komvc/KoGridData.h PRE-CREATION
krita/komvc/KoGridData.cpp PRE-CREATION
krita/komvc/KoMainWindow.h PRE-CREATION
krita/komvc/KoMainWindow.cpp PRE-CREATION
krita/komvc/KoOpenPane.h PRE-CREATION
krita/komvc/KoOpenPane.cpp PRE-CREATION
krita/komvc/KoOpenPaneBase.ui PRE-CREATION
krita/komvc/KoPageWidgetItem.h PRE-CREATION
krita/komvc/KoPart.h PRE-CREATION
krita/komvc/KoDocumentSectionToolTip.h PRE-CREATION
krita/komvc/KoDocumentSectionToolTip.cpp PRE-CREATION
krita/komvc/KoDocumentSectionView.h PRE-CREATION
krita/komvc/KoDocumentSectionView.cpp PRE-CREATION
krita/komvc/KoFilter.h PRE-CREATION
krita/komvc/KoFilter.cpp PRE-CREATION
krita/komvc/KoFilterChain.h PRE-CREATION
krita/komvc/KoFilterChain.cpp PRE-CREATION
krita/komvc/KoFilterChainLink.h PRE-CREATION
krita/komvc/KoFilterChainLink.cpp PRE-CREATION
krita/komvc/KoFilterChainLinkList.h PRE-CREATION
krita/komvc/KoFilterChainLinkList.cpp PRE-CREATION
krita/komvc/KoFilterEdge.h PRE-CREATION
krita/komvc/KoFilterEdge.cpp PRE-CREATION
krita/komvc/KoFilterEntry.h PRE-CREATION
krita/komvc/KoFilterEntry.cpp PRE-CREATION
krita/komvc/KoFilterGraph.h PRE-CREATION
krita/komvc/KoFilterGraph.cpp PRE-CREATION
krita/komvc/KoDockerManager.h PRE-CREATION
krita/komvc/KoDockerManager.cpp PRE-CREATION
krita/komvc/KoDockerManager_p.h PRE-CREATION
krita/komvc/KoDocument.h PRE-CREATION
krita/komvc/KoDocument.cpp PRE-CREATION
krita/komvc/KoDocumentAdaptor.h PRE-CREATION
krita/komvc/KoDocumentAdaptor.cpp PRE-CREATION
krita/komvc/KoDocumentEntry.h PRE-CREATION
krita/komvc/KoDocumentEntry.cpp PRE-CREATION
krita/komvc/KoDocumentInfo.h PRE-CREATION
krita/komvc/KoDocumentInfo.cpp PRE-CREATION
krita/komvc/KoDocumentInfoDlg.h PRE-CREATION
krita/komvc/KoDocumentInfoDlg.cpp PRE-CREATION
krita/komvc/KoDocumentInfoPropsPage.h PRE-CREATION
krita/komvc/KoDocumentInfoPropsPage.cpp PRE-CREATION
krita/komvc/KoDocumentSectionDelegate.h PRE-CREATION
krita/komvc/KoDocumentSectionDelegate.cpp PRE-CREATION
krita/komvc/KoDocumentSectionModel.h PRE-CREATION
krita/komvc/KoDocumentSectionPropertyAction_p.h PRE-CREATION
krita/komvc/CMakeLists.txt PRE-CREATION
krita/komvc/KoApplication.h PRE-CREATION
krita/komvc/KoApplication.cpp PRE-CREATION
krita/komvc/KoApplicationAdaptor.h PRE-CREATION
krita/komvc/KoApplicationAdaptor.cpp PRE-CREATION
krita/komvc/KoAutoSaveRecoveryDialog.h PRE-CREATION
krita/komvc/KoAutoSaveRecoveryDialog.cpp PRE-CREATION
krita/komvc/KoDetailsPane.h PRE-CREATION
krita/komvc/KoDetailsPane.cpp PRE-CREATION
krita/komvc/KoDetailsPaneBase.ui PRE-CREATION
krita/image/TODO e046314
krita/image/brushengine/kis_paintop_factory.h 7ff368f
krita/image/brushengine/kis_paintop_factory.cpp 37bdff6
krita/image/brushengine/kis_paintop_registry.h 69aafe3
krita/image/brushengine/kis_paintop_registry.cc 445aedc
krita/image/tests/CMakeLists.txt f585687
krita/image/tiles3/tests/CMakeLists.txt 802b675
krita/kis_splash_screen.h 2a1c7d4
krita/kis_splash_screen.cpp 72f6d85
krita/animator/kritaanimation.xml b98d707
krita/animator/kritaanimation_part_init.cpp bb1bf67
krita/animator/kritaanimationpart.desktop 84c2038
krita/animator/kritaanimationrc 180338d
krita/animator/main.cpp 628a462
krita/benchmarks/CMakeLists.txt 86794a5
krita/benchmarks/kis_projection_benchmark.cpp 662b2fc
krita/crashreporter/CMakeLists.txt 815f608
krita/data/krita.xml 6863e08
krita/gemini/MainWindow.cpp b7aab3e
krita/gemini/kritagemini.rc f072234
krita/image/CMakeLists.txt 7c5efa8
karbon/ui/dockers/KarbonLayerDocker.h eb8e517
krita/CMakeLists.txt 776181e
krita/animator/CMakeLists.txt 3d532b8
krita/animator/krita_animationdock.desktop 5fc467f
krita/animator/kritaanimation.desktop 56691dd
krita/animator/kritaanimation.rc d607c64
karbon/plugins/tools/KarbonGradientTool.h 9d9b936
karbon/plugins/tools/KarbonGradientTool.cpp 0556e4e
karbon/plugins/tools/KarbonPatternTool.h 4abd14d
karbon/plugins/tools/KarbonPatternTool.cpp 9ce2a55
karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.h 7b55f7c
karbon/plugins/tools/filterEffectTool/KarbonFilterEffectsTool.cpp 908bf5f
karbon/ui/KarbonPrintJob.h c1cc378
karbon/ui/KarbonView.cpp 2d01957
braindump/src/import/ToolDocker_p.h fecd9a9
braindump/plugins/stateshape/StateTool.h a7417fa
braindump/plugins/stateshape/StateTool.cpp cd352be
braindump/plugins/webshape/WebTool.h 7858f0d
braindump/plugins/webshape/WebTool.cpp cb80f24
braindump/src/View.cpp b93994b
braindump/src/import/DockerManager.h 6991668
braindump/src/import/DockerManager.cpp 0caf0e9
braindump/src/import/ToolDocker.h 6eb8f35
braindump/src/import/ToolDocker.cpp 0e5ef77
karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.h 3ca8efc
karbon/plugins/tools/CalligraphyTool/KarbonCalligraphyTool.cpp 607d7f1
CMakeLists.txt fa00fdd
krita/ui/canvas/kis_grid_decoration.cpp PRE-CREATION
krita/ui/canvas/kis_grid_manager.h 042cc90
krita/ui/canvas/kis_grid_manager.cpp 8d5fe7c
krita/ui/canvas/kis_infinity_manager.h f22b555
krita/ui/canvas/kis_infinity_manager.cpp e3f9758
krita/ui/canvas/kis_paintop_transformation_connector.h 34c498a
krita/ui/canvas/kis_paintop_transformation_connector.cpp 06c8039
krita/ui/canvas/kis_perspective_grid_decoration.h PRE-CREATION
krita/ui/canvas/kis_perspective_grid_decoration.cpp PRE-CREATION
krita/ui/canvas/kis_perspective_grid_manager.h 96846f3
krita/ui/canvas/kis_perspective_grid_manager.cpp f7ad056
krita/ui/canvas/kis_canvas_widget_base.cpp fec6cc8
krita/ui/canvas/kis_grid_decoration.h PRE-CREATION
krita/plugins/extensions/gmic/tests/CMakeLists.txt 1e8a958
krita/plugins/extensions/histogram/histogram.cc 80b9425
krita/plugins/extensions/imagesize/imagesize.cc ef35d56
krita/plugins/extensions/imagesplit/dlg_imagesplit.cpp 65026d4
krita/plugins/extensions/imagesplit/imagesplit.cpp dea4daf
krita/plugins/extensions/metadataeditor/metadataeditor.cc c8830cc
krita/plugins/extensions/offsetimage/offsetimage.cpp e46983f
krita/plugins/extensions/resourcemanager/resourcemanager.cpp 010c008
krita/plugins/extensions/resourcemanager/resourcemanager.rc 2fb607a
krita/plugins/extensions/resourcemanager/tests/CMakeLists.txt 1770760
krita/plugins/extensions/rotateimage/rotateimage.cc 383753b
krita/plugins/extensions/separate_channels/kis_channel_separator.cc 3d44b9d
krita/plugins/extensions/separate_channels/kis_separate_channels_plugin.cc fcb6858
krita/plugins/extensions/shearimage/shearimage.cc 4dc9b65
krita/plugins/filters/fastcolortransfer/kis_wdg_fastcolortransfer.cpp ca8568c
krita/plugins/filters/tests/CMakeLists.txt cb25f6f
krita/plugins/filters/unsharp/tests/CMakeLists.txt 2f52b5f
krita/plugins/formats/exr/tests/CMakeLists.txt 166b2f9
krita/plugins/formats/exr/tests/kis_exr_test.cpp 610a431
krita/plugins/formats/flipbook/kis_flipbook_import.cpp b091206
krita/plugins/formats/jpeg/tests/CMakeLists.txt 0d28164
krita/plugins/formats/png/tests/CMakeLists.txt fdd4494
krita/plugins/formats/ppm/tests/CMakeLists.txt c5b3e36
krita/plugins/formats/psd/tests/CMakeLists.txt 90600ff
krita/plugins/formats/tiff/tests/CMakeLists.txt c51fa3b
krita/plugins/formats/xcf/tests/CMakeLists.txt 8afc593
krita/plugins/paintops/defaultpaintops/brush/tests/CMakeLists.txt 0344ebb
krita/plugins/paintops/defaultpaintops/brush/tests/kis_brushop_test.cpp b44a55d
krita/plugins/tools/defaulttools/kis_tool_ellipse.cc bb74f66
krita/plugins/tools/defaulttools/kis_tool_fill.cc 8e99c13
krita/plugins/tools/defaulttools/kis_tool_gradient.cc 0b62d07
krita/plugins/tools/defaulttools/kis_tool_line.cc 7281673
krita/plugins/tools/defaulttools/kis_tool_line_helper.h 57970fd
krita/plugins/tools/defaulttools/kis_tool_line_helper.cpp b19216b
krita/plugins/tools/defaulttools/kis_tool_move.cc 4cfa4de
krita/plugins/tools/defaulttools/kis_tool_path.h 36db16a
krita/plugins/tools/defaulttools/kis_tool_path.cc ffbf5e7
krita/plugins/tools/defaulttools/kis_tool_rectangle.cc e7cd865
krita/plugins/tools/defaulttools/tests/CMakeLists.txt 3e78eb2
krita/plugins/tools/selectiontools/kis_tool_select_path.h 0bb252b
krita/plugins/tools/selectiontools/kis_tool_select_path.cc f85feef
krita/plugins/tools/tool_crop/kis_tool_crop.cc 277751d
krita/plugins/tools/tool_grid/kis_tool_grid.cc 471017f
krita/plugins/tools/tool_perspectivegrid/kis_tool_perspectivegrid.h 32f72d5
krita/plugins/tools/tool_perspectivegrid/kis_tool_perspectivegrid.cc af48810
krita/plugins/tools/tool_polygon/kis_tool_polygon.cc 85a4367
krita/plugins/tools/tool_polyline/kis_tool_polyline.cc 2bb4254
krita/plugins/tools/tool_text/kis_tool_text.h e646d9f
krita/plugins/tools/tool_text/kis_tool_text.cc 8b2556c
krita/plugins/tools/tool_transform2/kis_tool_transform.cc 62c5a7f
krita/sdk/tests/filestest.h cbc96d5
krita/sdk/tests/stroke_testing_utils.cpp 366d262
krita/sdk/tests/ui_manager_test.h d70c36a
krita/sketch/CMakeLists.txt c59a3be
krita/sketch/MainWindow.cpp 474b26c
krita/sketch/kritasketch.rc f072234
krita/ui/CMakeLists.txt 9708495
krita/ui/actions/kis_selection_action_factories.cpp 17094dc
krita/ui/canvas/kis_canvas2.h 3480834
krita/ui/canvas/kis_canvas2.cpp 60ade0b
krita/ui/canvas/kis_canvas_controller.h b022593
krita/ui/canvas/kis_canvas_controller.cpp c0a424c
krita/ui/canvas/kis_canvas_decoration.h 347ac08
krita/ui/canvas/kis_canvas_decoration.cc 5fda32b
krita/plugins/extensions/dockers/specificcolorselector/specificcolorselector_dock.cc 59e438e
krita/plugins/extensions/dockers/tasksetdocker/tasksetdocker_dock.h a65e961
krita/plugins/extensions/dropshadow/kis_dropshadow_plugin.cc 1f920a4
krita/plugins/extensions/dockers/imagedocker/imagedocker_dock.h 005e740
krita/plugins/extensions/dockers/lut/lutdocker_dock.h 56a438b
krita/plugins/extensions/dockers/lut/lutdocker_dock.cpp 9a116c4
krita/plugins/extensions/dockers/overview/overviewdocker_dock.h a8ff9f4
krita/plugins/extensions/dockers/overview/overviewdocker_dock.cpp a3c76b6
krita/plugins/extensions/dockers/palettedocker/colorsetchooser.cpp 5c11bba
krita/plugins/extensions/dockers/palettedocker/palettedocker_dock.h 6b87247
krita/plugins/extensions/dockers/palettedocker/palettedocker_dock.cpp c260beb
krita/plugins/extensions/dockers/patterndocker/patterndocker_dock.h 82a8a36
krita/plugins/extensions/dockers/patterndocker/patterndocker_dock.cpp a959200
krita/plugins/extensions/dockers/presetdocker/presetdocker_dock.h 20ec0fa
krita/plugins/extensions/dockers/presetdocker/presetdocker_dock.cpp c9e536b
krita/plugins/extensions/dockers/smallcolorselector/smallcolorselector_dock.h 91d8534
krita/plugins/extensions/dockers/specificcolorselector/specificcolorselector_dock.h 36026dd
krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.cpp 67db5b1
krita/plugins/extensions/dockers/defaultdockers/kis_palette_docker.h 99f985e7
krita/plugins/extensions/dockers/digitalmixer/digitalmixer_dock.h e4cf0a8
krita/plugins/extensions/dockers/flipbook/CMakeLists.txt 6d0fd8f
krita/plugins/extensions/dockers/flipbook/flipbookdocker_dock.h 57b8ec6
krita/plugins/extensions/dockers/flipbook/flipbookdocker_dock.cpp e8a924a
krita/plugins/extensions/dockers/historydocker/CMakeLists.txt 4cfa46c
krita/plugins/extensions/dockers/historydocker/HistoryDock.h 0f7c5e9
krita/plugins/extensions/dockers/animator/kis_timeline.cpp b04f961
krita/plugins/extensions/dockers/animator/kis_timeline_header.cpp 6fb9b93
krita/plugins/extensions/dockers/animator/krita_animator.desktop 316928f
krita/plugins/extensions/dockers/animator/onionskin_dock.h fc6fc4d
krita/plugins/extensions/dockers/animator/onionskin_dock.cpp 360b110
krita/plugins/extensions/dockers/artisticcolorselector/artisticcolorselector_dock.h 292f510
krita/plugins/extensions/dockers/artisticcolorselector/artisticcolorselector_dock.cpp de633b4
krita/plugins/extensions/dockers/channeldocker/channeldocker_dock.h a94cb61
krita/plugins/extensions/dockers/channeldocker/channeldocker_dock.cpp 87be27c
krita/plugins/extensions/dockers/colorslider/kis_color_slider_dock.h 9f64e99
krita/plugins/extensions/dockers/compositiondocker/compositiondocker_dock.h 247e9a2
krita/plugins/extensions/dockers/compositiondocker/compositiondocker_dock.cpp 2a55192
krita/plugins/extensions/dockers/defaultdockers/kis_layer_box.h 2007bc8
plugins/textshape/TextTool.cpp 70b79b5
sheets/part/View.cpp b9bb686
sheets/shape/TableTool.h 96f29a8
sheets/shape/TableTool.cpp 34654c3
sheets/ui/CellToolBase.h 58e0eab
sheets/ui/CellToolBase.cpp 8616f72
stage/part/tools/animationtool/KPrAnimationTool.h 2b49ca1
stage/part/tools/animationtool/KPrAnimationTool.cpp 96c4c8a
words/part/dialogs/KWPrintingDialog.h 87b1d71
words/part/pagetool/KWPageTool.h 45ad7d5
words/part/pagetool/KWPageTool.cpp 7935390
Diff: https://git.reviewboard.kde.org/r/119612/diff/
Testing
-------
Crash when:
* opening a new document after closing one
Broken connnections:
Object::connect: No such slot KisCanvasController::resetCanvasTransformations() in /home/boud/kde/src/calligra/krita/ui/kis_view2.cpp:473
Object::connect: (sender name: 'reset_canvas_transformations')
Broken guides:
krita(28323)/koffice (lib komain) KoRuler::createGuideToolConnection: No guides tool found, skipping connection
xmlgui error:
krita(28323)/kdeui (kdelibs) KXMLGUIClient::~KXMLGUIClient: 0x5f5ad48 deleted without having been removed from the factory first. This will leak standalone popupmenus and could lead to crashes.
File Attachments
----------------
Krita with two files open in tabs
https://git.reviewboard.kde.org/media/uploaded/files/2014/08/05/b75a3861-20fc-49e2-9cc2-eb20598f8e20__komvc.png
Thanks,
Boudewijn Rempt
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141114/10fa3c5e/attachment.htm>
More information about the calligra-devel
mailing list