Review Request 121088: Fix position of the Calligra logo based on height of the main menu

[Wojciech Kosowicz]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121088/#review70222
-----------------------------------------------------------



kexi/main/KexiMenuWidget.cpp
<https://git.reviewboard.kde.org/r/121088/#comment49095>

    please give proper name to the variables



kexi/main/KexiMenuWidget.cpp
<https://git.reviewboard.kde.org/r/121088/#comment49096>

    here and to the all the other digits in this method. Don't use magic numbers



kexi/main/KexiMenuWidget.cpp
<https://git.reviewboard.kde.org/r/121088/#comment49097>

    magic numbers again


- Wojciech Kosowicz


On Lis 10, 2014, 1:19 rano, Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121088/
> -----------------------------------------------------------
> 
> (Updated Lis 10, 2014, 1:19 rano)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Adam Pigg, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Fix position of the Calligra logo based on height of the main menu
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMenuWidget.h f5b418e6fac6a8fc030733bdd5b46b3485f71eae 
>   kexi/main/KexiMenuWidget.cpp 6acd27e277491991bca9dbd25525137300abc3cb 
>   kexi/main/KexiMenuWidget_p.h 2463b9b30c4f7c55cec061da5f3602af4d78df79 
> 
> Diff: https://git.reviewboard.kde.org/r/121088/diff/
> 
> 
> Testing
> -------
> 
> Logo well displayed regardless of the menu height.
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141110/47996896/attachment.htm>