Review Request 121064: Krita - KisPaintInformation::time should be qreal

Damien de Lemeny ddelemeny at gmail.com
Sat Nov 8 14:18:29 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121064/
-----------------------------------------------------------

Review request for Calligra.


Repository: calligra


Description
-------

Values in KisPaintInformation are interpolated between event's paint info
for each dab, time should be decimal rather than integer to be correctly
interpolated on high velocity strokes.

Note : this patch is not enough to completely fix the speed sensor as KisPaintInformation's timestamps are still garbage.


Diffs
-----

  krita/ui/tool/kis_tool_freehand_helper.cpp 26d4ccb 
  krita/image/kis_distance_information.h 70fa25e 
  krita/image/kis_distance_information.cpp 1c1c847 
  krita/image/brushengine/kis_paint_information.cc 264ad43 
  krita/image/brushengine/kis_paint_information.h 003a6c5 

Diff: https://git.reviewboard.kde.org/r/121064/diff/


Testing
-------

Compilation OK
Runtime OK

Expected results : 
A speed-bound stroke should have (almost) correct speed information and display changes correlated to speed.


Thanks,

Damien de Lemeny

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141108/e19114eb/attachment.htm>


More information about the calligra-devel mailing list