Review Request 119222: Make labels inline-editable

[Adam Pigg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119222/
-----------------------------------------------------------

(Updated Nov. 3, 2014, 9:24 a.m.)


Review request for Calligra and Jarosław Staniek.


Changes
-------

Rethink of how mode changes work.

This version uses a button centered in the label to switch between modes when clicked.
Button is currenty just a grey rectangle, intention is to paint a pencil or similar on it to signify it edits.
Button appears on mouse over.


Tested and works quite well, much more predictable than previous versions


Bugs: 336825
    http://bugs.kde.org/show_bug.cgi?id=336825


Repository: calligra


Description
-------

Usage:
Insert label
Double click to enter inline-edit mode
-Label text is selected and can be overwritten
Click away from item to exit edit mode
-Item text is updated with editor text


Diffs (updated)
-----

  libs/koreport/items/label/LabelEditButton.cpp PRE-CREATION 
  libs/koreport/items/text/KoReportDesignerItemText.cpp 7af69c4840bd910a7a8ee158d2c89d5f9096ed2a 
  libs/koreport/renderer/KoReportPrintRenderer.cpp 08428520a1e8f8d319069ade7dd4df96dfa2edb3 
  libs/koreport/renderer/KoReportScreenRenderer.cpp d19835b05a2f22c7db02f06af1fd0e149864dc2d 
  libs/koreport/renderer/odtframe/KoOdtFrameReportCheckBox.cpp 95aa265f874a77841c7b76820ef7bbcdbe89b3e9 
  libs/koreport/wrtembed/KoReportDesigner.cpp 2e1bd502c508ee429205bb7528518de16cc5444b 
  libs/koreport/wrtembed/reportscene.cpp 2e9c54d29c135c041db75d2a843ea5bd8318e1c1 
  libs/koreport/items/label/KoReportDesignerItemLabel.h 5aa3b48563216db6dc8bd1f8f4c43a7c7bf7dce8 
  libs/koreport/items/label/KoReportDesignerItemLabel.cpp 8bebbd218fb7f432731af646703cd5e31c3b5245 
  libs/koreport/items/label/LabelEditButton.h PRE-CREATION 
  libs/koreport/CMakeLists.txt d8aea281ad0536e1423210014f09f616ee09f9af 
  libs/koreport/items/check/KoReportDesignerItemCheck.cpp ac628616b52b4769232a55af07a51bea9fd80c0a 
  libs/koreport/items/field/KoReportDesignerItemField.cpp f386f9b99c9584f1122fbee542fb708bf5121f16 
  libs/koreport/items/image/KoReportDesignerItemImage.cpp b129299e160c65d1d9f6ed691800e1d6095a5364 
  libs/koreport/items/label/BoundedTextItem.h PRE-CREATION 
  libs/koreport/items/label/BoundedTextItem.cpp PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/119222/diff/


Testing
-------

Inserted label on new report and checked usage

Loaded existing report and ensured labels are editiable


Thanks,

Adam Pigg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20141103/2a8dd715/attachment.htm>