Review Request 118074: Added storing previous find/replace queries into kexifinddialog

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118074/#review58644
-----------------------------------------------------------

Ship it!


Good job! Please commit to master and 2.8.

- Jarosław Staniek


On May 10, 2014, 4:08 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118074/
> -----------------------------------------------------------
> 
> (Updated May 10, 2014, 4:08 p.m.)
> 
> 
> Review request for Calligra, Adam Pigg and Jarosław Staniek.
> 
> 
> Bugs: 334514
>     http://bugs.kde.org/show_bug.cgi?id=334514
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> KHistoryComboBox AddToHistory slot was not connected to any signal therefore it never stored previous queries. Connects were added that work when combobox is activated or when find/replace/replaceall button is clicked. To avoid incompability of signals issue customised slots were created. UI file contains setting maxCount value of two comboboxes to 10. Issue can be find also in calligra/2.8 branch.
> 
> 
> Diffs
> -----
> 
>   kexi/main/kexifinddialog.h 9f32ce9 
>   kexi/main/kexifinddialog.cpp 88e4f5e 
>   kexi/main/kexifinddialog.ui 09b570d 
> 
> Diff: https://git.reviewboard.kde.org/r/118074/diff/
> 
> 
> Testing
> -------
> 
> After activiting combo with text or clicking appropriate button combobox history should filled up to 10 results
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140528/cfa9a48d/attachment.htm>