Review Request 118175: Add git HEAD hash and branch name in Kexi about dialog
Adam Pigg
adam at piggz.co.uk
Wed May 21 20:56:04 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118175/#review58248
-----------------------------------------------------------
Ship it!
Ship It!
- Adam Pigg
On May 16, 2014, 10:04 p.m., Jarosław Staniek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118175/
> -----------------------------------------------------------
>
> (Updated May 16, 2014, 10:04 p.m.)
>
>
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.
>
>
> Repository: calligra
>
>
> Description
> -------
>
> This extra info *precisely* specifies version used if compiled from git to give extra convenience for bug reports.
>
> Krita already uses HEAD hash, here we're adding branch name too.
>
> See http://kexi-project.org/pics/forum/2014/about-kexi-git.jpg
>
> Added get_git_branch() to GetGitRevisionDescription.
>
> Do you want the same for other Calligra apps?
>
>
> Diffs
> -----
>
> CMakeLists.txt b65d702f62593651da4c488a56edb8e94cda9620
> cmake/modules/GetGitRevisionDescription.cmake c8d27f2e8ce494c96404086ce58982239916a44c
> kexi/core/kexiaboutdata.cpp 67c74156084b0ae79d62820687ca35026d1fb3a5
> libs/main/calligragitversion.h.cmake 4fe04acb6b52957be223d6135e8c27c00533e843
>
> Diff: https://git.reviewboard.kde.org/r/118175/diff/
>
>
> Testing
> -------
>
> Shows as expected
>
>
> Thanks,
>
> Jarosław Staniek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140521/d4b5d41c/attachment.htm>
More information about the calligra-devel
mailing list