Review Request 118232: Don't allow the scroll area in a KoModeBox to be focused.

Commit Hook null at kde.org
Wed May 21 16:56:13 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118232/#review58236
-----------------------------------------------------------


This review has been submitted with commit 082076fb0b9c20950695a5d1b02cc9fdd93f228a by Marijn Kruisselbrink to branch master.

- Commit Hook


On May 20, 2014, 11:42 p.m., Marijn Kruisselbrink wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118232/
> -----------------------------------------------------------
> 
> (Updated May 20, 2014, 11:42 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Currently everytime you click a button to change formatting of a cell in sheets the scrollarea gets keyboard focus, making further editing very annoying. This fixes that behavior.
> I'm not sure if any other code/UI depends on this scroll area being focusable though?
> (two years ago I made the same change in 5e2cc2ee27a50806b0c2eb16724ad704a6450d9f for KoToolDocker)
> 
> 
> Diffs
> -----
> 
>   libs/main/KoModeBox.cpp 91f71e2 
> 
> Diff: https://git.reviewboard.kde.org/r/118232/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Marijn Kruisselbrink
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140521/624b54df/attachment.htm>


More information about the calligra-devel mailing list