Review Request 118027: Properly populate Create toolbar with icons

Wojciech Kosowicz pcellix at gmail.com
Tue May 13 20:16:47 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118027/#review57892
-----------------------------------------------------------


I tried applying patch and got the following message:

error: patch failed: kexi/core/kexipartinfo.cpp:232
error: kexi/core/kexipartinfo.cpp: patch does not apply
error: patch failed: kexi/main/KexiMainWindow_p.h:1335
error: kexi/main/KexiMainWindow_p.h: patch does not appl

- Wojciech Kosowicz


On May 12, 2014, 7:17 p.m., Jarosław Staniek wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118027/
> -----------------------------------------------------------
> 
> (Updated May 12, 2014, 7:17 p.m.)
> 
> 
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This regression has been introduced by commit decd43c010eb6ee "Do not
> crash when Kexi is unable to find plugins" (REVIEW:117759).
> Look at the bug in Info::newObjectAction() and become fan of thorough
> reviews :)
> 
> 
> Diffs
> -----
> 
>   kexi/core/kexipartinfo.h d24c83bad3304d1d16835c7721a043f25383334d 
>   kexi/core/kexipartinfo.cpp 3c7f8451b0787d74ffff2321a5e69753d001a774 
>   kexi/main/KexiMainWindow_p.h 547158209dc6ec2678dd6abd714739e3adc7c4ea 
> 
> Diff: https://git.reviewboard.kde.org/r/118027/diff/
> 
> 
> Testing
> -------
> 
> The toolbar is properly populated out of the box
> 
> 
> Thanks,
> 
> Jarosław Staniek
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140513/2ea3c646/attachment.htm>


More information about the calligra-devel mailing list