Review Request 118044: odb file reader(kexi)

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118044/#review57814
-----------------------------------------------------------


Next iteration of my review. 

Disclaimer: I am not Java developer so I am use code snippets as inspiration and looking up API docs when needed.

The progress looks nice already!

1. I propose to look at the guide, http://www.hsqldb.org/doc/1.8/guide/apb.html for inspiration e.g. to see how they catch exceptions and try to do the same.

2. Maybe you already know, to understand why there are several files to extract in this code you can read this chapter of the Guide: http://www.hsqldb.org/doc/guide/running-chapt.html#rgc_hsqldb_db.

3. Regarding security and reliability please unpack the to a temporary directory created using File.createTempDirectory(): http://docs.oracle.com/javase/7/docs/api/java/nio/file/Files.html#createTempDirectory%28java.nio.file.Path,%20java.lang.String,%20java.nio.file.attribute.FileAttribute...%29 
This will make the paths unique.

4. Please apply this coding style (especially 4 spaces for indentation, no tabs): http://techbase.kde.org/Policies/Kdelibs_Coding_Style

5. I propose to rename the class to OdbReader and put into a kexi/migration/odb/reader/ dir.


kexi/migration/odb/myDbTwo.java
<https://git.reviewboard.kde.org/r/118044/#comment40252>

    I propose to split the code to uncompressDatabase() and processDatabase() methods



kexi/migration/odb/myDbTwo.java
<https://git.reviewboard.kde.org/r/118044/#comment40246>

    let's use IOException as in www.devx.com/getHelpOn/10MinuteSolution/20447



kexi/migration/odb/myDbTwo.java
<https://git.reviewboard.kde.org/r/118044/#comment40247>

    I propose to typically count k from 0 to numberOfColumns-1


- Jarosław Staniek


On May 8, 2014, 5:12 p.m., harshita mistry wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118044/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 5:12 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> A java program that formats odb files and reads data from hsqldb using hsqldb jdbc driver.
> 
> 
> Diffs
> -----
> 
>   kexi/migration/odb/myDbTwo.java PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118044/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> harshita mistry
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140512/ae62710c/attachment.htm>