Review Request 118028: Separate desktop files for PPT and PPTX support by Okular ODP plugin, note runtime deps to packagers

[Commit Hook]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118028/#review57826
-----------------------------------------------------------


This review has been submitted with commit 1f4d1240b3ae63457492d2288a993bbfc4760a8e by Friedrich W. H. Kossebau to branch master.

- Commit Hook


On May 6, 2014, 11:04 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118028/
> -----------------------------------------------------------
> 
> (Updated May 6, 2014, 11:04 p.m.)
> 
> 
> Review request for Calligra and Sven Langkamp.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> It was found (by missing deps in OpenSUSE packages) that Okular crashes (for some yet to be investigated reason) if the Calligra Okular ODP plugin is installed, but not the Stage part.
> 
> This patch notes this runtime dependency in the README.PACKAGERS.
> 
> It also splits the definition of the PPT and PPTX support into separate desktop files, only installed if the needed filters are also built.
> 
> Possibly should be also backported to 2.8
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt a32d6b4 
>   README.PACKAGERS 2a686d6 
>   cmake/productsets/all.cmake 8e82b40 
>   cmake/productsets/desktop.cmake 4e85bc8 
>   extras/okularodpgenerator/libokularGenerator_odp.desktop 964bf21 
>   extras/okularodpgenerator/okularApplication_odp.desktop 788825e 
>   extras/okularodpgenerator/okularOdp.desktop 7b1a8d3 
>   filters/stage/powerpoint/CMakeLists.txt 8d7df54 
>   filters/stage/powerpoint/libokularGenerator_powerpoint_calligra.desktop PRE-CREATION 
>   filters/stage/powerpoint/okularApplication_powerpoint_calligra.desktop PRE-CREATION 
>   filters/stage/powerpoint/okularPowerpoint_calligra.desktop PRE-CREATION 
>   filters/stage/pptx/CMakeLists.txt 9a07c37 
>   filters/stage/pptx/libokularGenerator_pptx_calligra.desktop PRE-CREATION 
>   filters/stage/pptx/okularApplication_pptx_calligra.desktop PRE-CREATION 
>   filters/stage/pptx/okularPptx_calligra.desktop PRE-CREATION 
> 
> Diff: https://git.reviewboard.kde.org/r/118028/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140512/b17a8c4a/attachment.htm>