Review Request 117803: Update list of reserved keywords for sqlite in Kexi
Jarosław Staniek
staniek at kde.org
Fri May 9 22:52:03 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117803/#review57653
-----------------------------------------------------------
It appears that this review should have title like "Added toUpper for a word to be checked if is KexiSql keyword" as it's bound to commit de07f92717012158b83ca0 to master. Please update to avoid confusion.
Also you forgot to cherry-pick to calligra/2.8 - just did that. Bug https://bugs.kde.org/show_bug.cgi?id=332160 is for calligra 2.8.
- Jarosław Staniek
On May 2, 2014, 11:43 p.m., Wojciech Kosowicz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117803/
> -----------------------------------------------------------
>
> (Updated May 2, 2014, 11:43 p.m.)
>
>
> Review request for Calligra and Jarosław Staniek.
>
>
> Bugs: 332160
> http://bugs.kde.org/show_bug.cgi?id=332160
>
>
> Repository: calligra
>
>
> Description
> -------
>
> words inside keywords.cpp are all capital letters and word that was given to be checked if it is a kexisql keyword was not changed to capital thefore it was not filtered
>
>
> Diffs
> -----
>
> libs/db/driver.cpp efa94e3
>
> Diff: https://git.reviewboard.kde.org/r/117803/diff/
>
>
> Testing
> -------
>
> Now it is possible to create table, field that is the same sqlite keyword
>
>
> Thanks,
>
> Wojciech Kosowicz
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140509/7678118c/attachment.htm>
More information about the calligra-devel
mailing list