Review Request 117956: Updated list of sqlite keywords from sqlite3080403 (kexi)

[Jaroslaw Staniek]

Good question. Changes I requested in the script today do not affect these
generated files so I propose to push them.

On Friday, 9 May 2014, Wojciech Kosowicz <pcellix at gmail.com> wrote:
> This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117956/
>
> On May 9th, 2014, 2:16 p.m. UTC, Jarosław Staniek wrote:
>
> Good work! Please push both to calligra/2.8 and master.
>
> On May 9th, 2014, 2:39 p.m. UTC, Wojciech Kosowicz wrote:
>
> Thanks, before pushing I have a question regarding code formatting. I
noticed that in the previous edition there were used 4 spaces. Now there's
2 tabs. I have not modified any part of the script regarding coding style.
Still I want to ensure that is okay to push the way it is. So, is it okay?
>
> if any coding style required then can be introduced easily, still I'm not
100% if to introduce and rerun script as this is how the script was
originally accepted
>
> - Wojciech
>
> On May 8th, 2014, 1:04 p.m. UTC, Wojciech Kosowicz wrote:
>
> Review request for Calligra and Jarosław Staniek.
> By Wojciech Kosowicz.
>
> Updated May 8, 2014, 1:04 p.m.
>
> Repository: calligra
>
> Description
>
> I downloaded sqlite3080403 sources and using script sql_keywords got a
generated list of specific sqlite keywords. There are new words in
consideration to the previous version. sql_keywords I had to modify as it
does not work in it current form (after finishing all changes for all the
three databases I will upload modified version to review).
>
> Diffs
>
> libs/db/drivers/sqlite/sqlitekeywords.cpp (735f446)
>
> View Diff

-- 
regards / pozdrawiam, Jaroslaw Staniek
 Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org
 Qt for Tizen | http://qt-project.org/wiki/Tizen
 Qt Certified Specialist | http://www.linkedin.com/in/jstaniek
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140509/eacf5b9f/attachment.htm>