Review Request 117966: Updated script for generating databases keywords in Kexi

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117966/#review57641
-----------------------------------------------------------


Added explanation how to move choice of the filenames to the caller of the script: as $1 $2 $3


kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment40085>

    -> Put three DB source



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment40084>

    -> then run /path/to/sql_keywords.sh {sqlite-archive} {mysql-archive} {pgsql-archive} (all 3 args required)
    



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment40086>

    Please add: 
    if [ $# -lt 3 ] ; then
      echo "Please specify {sqlite-archive} {mysql-archive} {pgsql-archive} arguments"
      exit 1
    fi
    



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment40087>

    please remove this line, see below note
    



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment40088>

    Instead of the case let's just add:
    
    archive="$1"
    
    It would be good to also add:
    
    [ -r ${archive} ] || exit 1
    



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment40089>

    Instead of the case let's just add:
    
    archive="$2"
    
    It would be good to also add:
    
    [ -r ${archive} ] || exit 1
    



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment40090>

    Instead of the case let's just add:
    
    archive="$3"
    
    It would be good to also add:
    
    [ -r ${archive} ] || exit 1
    


- Jarosław Staniek


On May 8, 2014, 1:23 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117966/
> -----------------------------------------------------------
> 
> (Updated May 8, 2014, 1:23 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch contains changes for sql_keywords.sh script that generates source files that contains keywords for specific database technology (kexisql, sqlite, postrsql, mysql). 
> I did my best still I think functions getPostgreSQLKeywords and getSQLiteKeywords can be done in a better (old mechanism did not work but I think there can be better ways than what I came up with.
> Every suggestions are welcome
> TODO:
> updating comments as some functions changed names/attributes
> 
> 
> Diffs
> -----
> 
>   kexi/tools/sql_keywords/sql_keywords.sh 6bcc5de 
> 
> Diff: https://git.reviewboard.kde.org/r/117966/diff/
> 
> 
> Testing
> -------
> 
> 4 files that contained keywords are generated and they do contain them
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140509/1fcb50c8/attachment.htm>