Review Request 118056: Removing non-direct children of kexiwindow from to be deleted list
Jarosław Staniek
staniek at kde.org
Fri May 9 15:09:51 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118056/#review57636
-----------------------------------------------------------
Ship it!
Good find! Works for me. Please push both to calligra/2.8 and master with FIXED-IN:2.8.3 and BUG:334234 lines.
PS: Why to add the patch as an attachment?
- Jarosław Staniek
On May 8, 2014, 8:44 p.m., Wojciech Kosowicz wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118056/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 8:44 p.m.)
>
>
> Review request for Calligra and Jarosław Staniek.
>
>
> Bugs: 334234
> http://bugs.kde.org/show_bug.cgi?id=334234
>
>
> Repository: calligra
>
>
> Description
> -------
>
> The findChildren method returned all the children even those non-direct When deleting view it propagates from parent to children. Therefore situation occured when view was first indirectly deleted and them directly. This checks for the non-direct childs and deletes from the list
>
>
> Diffs
> -----
>
> kexi/core/KexiWindow.cpp bcb552a
>
> Diff: https://git.reviewboard.kde.org/r/118056/diff/
>
>
> Testing
> -------
>
> Query designer should no longer crash
>
>
> File Attachments
> ----------------
>
> 0001-Removing-non-direct-children-of-kexiwindow-from-to-b.patch
> https://git.reviewboard.kde.org/media/uploaded/files/2014/05/08/e32e0428-6e85-4898-a425-ba12a1e4c7fc__0001-Removing-non-direct-children-of-kexiwindow-from-to-b.patch
>
>
> Thanks,
>
> Wojciech Kosowicz
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140509/db557080/attachment.htm>
More information about the calligra-devel
mailing list