Review Request 118046: Fix crash introduced in reports after porting forms to Qt4
Adam Pigg
adam at piggz.co.uk
Thu May 8 19:54:33 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118046/#review57599
-----------------------------------------------------------
Ship it!
Tested and works ok. Navigator looks good.
kexi/widget/utils/kexirecordnavigator.h
<https://git.reviewboard.kde.org/r/118046/#comment40060>
maybe insertLeftOfHorizontalScrollBar ?
- Adam Pigg
On May 8, 2014, 8:41 a.m., Jarosław Staniek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118046/
> -----------------------------------------------------------
>
> (Updated May 8, 2014, 8:41 a.m.)
>
>
> Review request for Calligra, Andrius da Costa Ribas, Oleg Kukharchuk, Adam Pigg, Dimitrios Tanis, Tomasz Olszak, Radosław Wicik, and Wojciech Kosowicz.
>
>
> Bugs: 334293
> http://bugs.kde.org/show_bug.cgi?id=334293
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Fix crash introduced in reports after porting forms to Qt4
>
> (that was commit 1c53aa8b9e09681)
>
> Put the page navigator is put aside of the report area's horizontal scroll bar
> like we do in table and form view.
>
>
> Diffs
> -----
>
> kexi/plugins/forms/kexiformscrollview.cpp 48333f04dec23ac1e0c4740a0e30c9c5a62244e1
> kexi/plugins/reports/kexireportview.cpp df1e17728d8145cdf4fba4460a111d7f76cee5ee
> kexi/widget/utils/kexirecordnavigator.h 64b57304d6fd47d6a958603630eb24d9a15abc60
> kexi/widget/utils/kexirecordnavigator.cpp dce9e68431f7abaf64d184bedce65ee47c9a5754
>
> Diff: https://git.reviewboard.kde.org/r/118046/diff/
>
>
> Testing
> -------
>
> Navigators of report/form/table views function properly
>
>
> Thanks,
>
> Jarosław Staniek
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140508/bd030637/attachment.htm>
More information about the calligra-devel
mailing list