Review Request 117966: Updated script for generating databases keywords in Kexi

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117966/#review57450
-----------------------------------------------------------



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment39970>

    Add your copyright here
    



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment39963>

    why this line?



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment39969>

    Add your copyright here
    



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment39961>

    Does i=${i}+1 work in bash?
    
    $i isn't used anyway so this and  line 107 can be removed, right?



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment39962>

    Why this change? Does it work in bash?



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment39964>

    why?



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment39971>

    use spaces, not tabs



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment39968>

    debug not needed



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment39965>

    How about requiring exact filenames as args for this script? In case when (by accident or not) we have other matching archives in the same dir, the script behaves not as expected.
    
    Look that for mysql and postgresql, specific prefixes are in the 'case'. It's better not to use * with ls but specifying exact filenames that are specified by the user of the script.
    



kexi/tools/sql_keywords/sql_keywords.sh
<https://git.reviewboard.kde.org/r/117966/#comment39966>

    debug not needed


- Jarosław Staniek


On May 2, 2014, 11:38 p.m., Wojciech Kosowicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117966/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 11:38 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> This patch contains changes for sql_keywords.sh script that generates source files that contains keywords for specific database technology (kexisql, sqlite, postrsql, mysql). 
> I did my best still I think functions getPostgreSQLKeywords and getSQLiteKeywords can be done in a better (old mechanism did not work but I think there can be better ways than what I came up with.
> Every suggestions are welcome
> TODO:
> updating comments as some functions changed names/attributes
> 
> 
> Diffs
> -----
> 
>   kexi/tools/sql_keywords/sql_keywords.sh 6bcc5de 
> 
> Diff: https://git.reviewboard.kde.org/r/117966/diff/
> 
> 
> Testing
> -------
> 
> 4 files that contained keywords are generated and they do contain them
> 
> 
> Thanks,
> 
> Wojciech Kosowicz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140506/c4d65531/attachment.htm>