Review Request 117949: Fix Krita filter dialog to update dialog title if another filter is selected inside

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117949/#review57146
-----------------------------------------------------------

Ship it!


Ship It!

- Boudewijn Rempt


On May 2, 2014, 3:49 p.m., Friedrich W. H. Kossebau wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117949/
> -----------------------------------------------------------
> 
> (Updated May 2, 2014, 3:49 p.m.)
> 
> 
> Review request for Calligra and Cyrille Berger Skott.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The current filter dialog has a hiddable list of all filter (configurations). If the user opens the view, by moving the splitter on the left into the middle of the dialog, and then in that list selects another filter (configuration), that filter (configuration) is activated and the UI adapts to the configuration.
> But it does not adapt the title of the dialog.
> 
> Attached patch fixes that.
> 
> The patch also prefixes the dialog title with some "Filter: ", to make it more obvious what this dialog is about.
> 
> KisFilterSelectorWidget::currentFilterName() is removed completely and the only current caller changed to query that property itself. That method relied on callers only calling it if a filter was selected. So I kept that and also made that caller not check if there is a filter or not. Not sure if that should not be made more safe.
> 
> 
> Diffs
> -----
> 
>   krita/ui/dialogs/kis_dlg_adjustment_layer.cc 13f4e70 
>   krita/ui/dialogs/kis_dlg_filter.h cc103ef 
>   krita/ui/dialogs/kis_dlg_filter.cpp 844ab1d 
>   krita/ui/widgets/kis_filter_selector_widget.h 0b99032 
>   krita/ui/widgets/kis_filter_selector_widget.cc bd08586 
> 
> Diff: https://git.reviewboard.kde.org/r/117949/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Friedrich W. H. Kossebau
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140502/90d281cb/attachment.htm>