Review Request 117803: Update list of reserved keywords for sqlite in Kexi

Wojciech Kosowicz pcellix at gmail.com
Thu May 1 23:33:07 BST 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117803/
-----------------------------------------------------------

(Updated May 1, 2014, 10:33 p.m.)


Review request for Calligra and Jarosław Staniek.


Changes
-------

the real reason was that the words inside keyword.cpp are all capital letters and word that was given to be checked if it is a kexisql keyword was not changed to capital thefore it was not filtered


Bugs: 332160
    http://bugs.kde.org/show_bug.cgi?id=332160


Repository: calligra


Description
-------

Not all the keywords to escape in sqlite were listed. Therefore it was not possible to create for example table called 'group' cause escape mechanism did not filtered this word. I updated the list using keywords given here:
http://sqlite.org/lang_keywords.html 


Diffs (updated)
-----

  libs/db/driver.cpp efa94e3 

Diff: https://git.reviewboard.kde.org/r/117803/diff/


Testing
-------

Now it is possible to create table, field that is the same sqlite keyword


Thanks,

Wojciech Kosowicz

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140501/5762d3cd/attachment.htm>


More information about the calligra-devel mailing list