Review Request 117937: Remove hardcoded margins from Krita filter dialog, use normal buttonbox for ok/cancel
Friedrich W. H. Kossebau
kossebau at kde.org
Thu May 1 23:28:06 BST 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117937/
-----------------------------------------------------------
Review request for Calligra and Boudewijn Rempt.
Repository: calligra
Description
-------
The Ok & Cancel buttons in the Krita filter dialog are not following the standards, also will not adapt to different Cancel/Ok order on other platforms (e.g. Gnome OS). Also are some margins hardcoded to certain random pixel sizes, which is a problem on HiDPI screens and with styles where those margins do not match the built-in ones.
These two patches remove some hard-coded margins, use a QButtonBox for the Ok and Cancel buttons and also some ";" to labels where they are missing.
Diffs
-----
krita/plugins/filters/blur/wdg_motion_blur.ui 5377ccf
krita/plugins/filters/blur/wdg_lens_blur.ui e7daea4
krita/plugins/filters/blur/wdg_gaussian_blur.ui 728f608
krita/plugins/filters/colorsfilters/kis_hsv_adjustment_filter.cpp 85f476c
krita/ui/dialogs/kis_dlg_filter.cpp 4fd86ca
krita/ui/forms/wdgfilterdialog.ui 7a1e3c6
krita/ui/forms/wdgfilterselector.ui c9d87c7
Diff: https://git.reviewboard.kde.org/r/117937/diff/
Testing
-------
File Attachments
----------------
Before, by example of Levels filter
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/01/d91edd9c-9488-4d5f-ab51-a8ecd9907de5__filterdialogbefore.png
After, by example of levels filter
https://git.reviewboard.kde.org/media/uploaded/files/2014/05/01/cbb4ea9c-90a8-4b0d-90e0-febdca546f98__filterdialogafter.png
Thanks,
Friedrich W. H. Kossebau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140501/ea7abf44/attachment.htm>
More information about the calligra-devel
mailing list