Review Request 116915: Fix Bug 305618

Thorsten Zachmann t.zachmann at zagge.de
Wed Mar 26 17:55:32 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116915/#review54058
-----------------------------------------------------------

Ship it!


I committed the review request after a small fix. Good work. Please mark the review request as submitted.

- Thorsten Zachmann


On March 26, 2014, 5:53 a.m., Wenchao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116915/
> -----------------------------------------------------------
> 
> (Updated March 26, 2014, 5:53 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The patch tries to add a new function about "add this slide animation for all slides". After the checkbox is checked, the presentation will use the same slide transition for all slides.
> The function "slotApplyToAllSlides()" is defined in file KPrPageEffectDocker.cpp which implements the task.
> 
> 
> Diffs
> -----
> 
>   stage/part/tools/animationtool/KPrPageEffectDocker.cpp 836d687 
>   stage/part/tools/animationtool/KPrPageEffectDocker.h e7a5277 
>   stage/part/commands/KPrPageEffectSetCommand.h ec95f07 
>   stage/part/commands/KPrPageEffectSetCommand.cpp f44953f 
> 
> Diff: https://git.reviewboard.kde.org/r/116915/diff/
> 
> 
> Testing
> -------
> 
> Tested manually.
> 
> 
> Thanks,
> 
> Wenchao Li
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140326/7e2049b9/attachment.htm>


More information about the calligra-devel mailing list