Review Request 116949: close all tabs command added

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116949/#review53863
-----------------------------------------------------------



kexi/main/KexiMainWindow.cpp
<https://git.reviewboard.kde.org/r/116949/#comment37762>

    Much better. Now:
    
    Return false if closeWindow() returned false at least once. Now when you have two tabs and they retutn 'false, true' respectively, you' returning true (you should return false).
    
    On closeWindow() == cancelled immediately return cancelled. 
    
    



kexi/main/KexiMainWindow.cpp
<https://git.reviewboard.kde.org/r/116949/#comment37763>

    When there are zero tabs you're returning uninitialized value.


- Jarosław Staniek


On March 23, 2014, 9:36 p.m., Vishwa Modi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116949/
> -----------------------------------------------------------
> 
> (Updated March 23, 2014, 9:36 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> new KAction m_closeAction2 is added and closeAllTabs() function is added.
> 
> 
> Diffs
> -----
> 
>   kexi/main/KexiMainWindow.h 3d76bb2 
>   kexi/main/KexiMainWindow.cpp e916281 
> 
> Diff: https://git.reviewboard.kde.org/r/116949/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishwa Modi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140323/4806c78d/attachment.htm>