Review Request 116844: update minimum cmake requirement to 2.8.10, use cmake built-in FindGLEW.cmake

Yue Liu yue.liu at mail.com
Sun Mar 23 21:09:10 GMT 2014


ok. I'll revert the change.

On Sun, Mar 23, 2014 at 4:46 PM, Jaroslaw Staniek <staniek at kde.org> wrote:
> I have 2.8.9 on my pretty modern machine. Also I know people using Ubuntu
> 12.10 or 12.04 not willing to install backports for THIS single reason :)
>
> Summing up I really recommend to just backport; I've followed this approach
> with mysql/pgsql detection code and I am still using
> FindCalligraSqlite.cmake.
> Convenience for users is a priority.
>
>
>
> On 23 March 2014 21:37, Yue Liu <yue.liu at mail.com> wrote:
>>
>> We can do that if there are platforms without 2.8.10 we need to support.
>>
>> On Sun, Mar 23, 2014 at 2:29 PM, Jaroslaw Staniek <staniek at kde.org> wrote:
>> > Hi, can't we just back port the cake file?
>> >
>> >
>> > On Sunday, 23 March 2014, Yue Liu <yue.liu at mail.com> wrote:
>> >> This is an automatically generated e-mail. To reply, visit:
>> >> https://git.reviewboard.kde.org/r/116844/
>> >>
>> >> This change has been marked as submitted.
>> >>
>> >> Review request for Calligra.
>> >> By Yue Liu.
>> >>
>> >> Updated March 23, 2014, 6:22 p.m.
>> >>
>> >> Repository: calligra
>> >>
>> >> Description
>> >>
>> >> Current FindGLEW doesn't work on OSX. The one from cmake >= 2.8.10
>> >> works.
>> >> From information on http://pkgs.org/search/?query=cmake&type=name, most
>> >> distro already has that version.
>> >> Cent6 needs EPEL repo, Debian Wheezy needs backports repo, slackware
>> >> 14.0
>> >> needs ktown repo, Ubuntu 12.04 needs Kubuntu backports, Ubuntu 12.10
>> >> not
>> >> supported, newer version of these distros and other popular distros are
>> >> supported. Homebrew and Macports supported, not sure the situation on
>> >> Windows.
>> >>
>> >> Testing
>> >>
>> >> Works on OSX 10.9.2, Windows 7 x64, Arch Linux x64.
>> >>
>> >> Diffs
>> >>
>> >> CMakeLists.txt (e376487)
>> >> cmake/modules/FindGLEW.cmake (adcc452)
>> >> krita/CMakeLists.txt (b9745ce)
>> >>
>> >> View Diff
>> >
>> > --
>> > regards / pozdrawiam, Jaroslaw Staniek
>> >  Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org
>> >  Qt for Tizen | http://qt-project.org/wiki/Tizen
>> >  Qt Certified Specialist | http://www.linkedin.com/in/jstaniek
>> >
>
>
>
>
> --
> regards / pozdrawiam, Jaroslaw Staniek
>  Kexi & Calligra & KDE | http://calligra.org/kexi | http://kde.org
>  Qt for Tizen | http://qt-project.org/wiki/Tizen
>  Qt Certified Specialist | http://www.linkedin.com/in/jstaniek



More information about the calligra-devel mailing list