Review Request 115116: Disable KoM2MMLForumulaTool also on MinGW

Commit Hook null at kde.org
Sun Mar 23 12:55:04 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115116/#review53807
-----------------------------------------------------------


This review has been submitted with commit b5832b98ecaad669827fa35cc9cc30e7e443001c by Andrius da Costa Ribas to branch calligra/2.8.

- Commit Hook


On Jan. 19, 2014, 4:01 a.m., Andrius da Costa Ribas wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115116/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2014, 4:01 a.m.)
> 
> 
> Review request for Calligra and kdewin.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Those files generated by flex (is this flex/yacc?) also fail to build on MinGW. For MinGW I had tried renaming the conflicting token names (CHAR and CAL to CHARTOKEN and CALTOKEN) but besides succeding to build the "Show MathML" button does not work for me, so I don't know if this would be a correct fix (although even so it would be only for MinGW).
> 
> 
> Diffs
> -----
> 
>   plugins/formulashape/CMakeLists.txt 015cb8f 
>   plugins/formulashape/KoFormulaShapePlugin.cpp 5d5ed61 
> 
> Diff: https://git.reviewboard.kde.org/r/115116/diff/
> 
> 
> Testing
> -------
> 
> Builds on both MinGW and MSVC.
> 
> 
> Thanks,
> 
> Andrius da Costa Ribas
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140323/ff93fa56/attachment.htm>


More information about the calligra-devel mailing list