Review Request 116611: Eigen3 support

Maximiliano Curia maxy at debian.org
Fri Mar 21 20:48:54 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116611/
-----------------------------------------------------------

(Updated March 21, 2014, 8:48 p.m.)


Review request for Calligra.


Changes
-------

Updated patch, removes the unused EIGEN3_SUPPORT, polishes the minverse.


Repository: calligra


Description
-------

Hi,

In Debian eigen2 was removed from the archive, so, this is the patch we are using to support eigen3. The pathch was originaly developed by Anton Gladky, and later modified by the debian calligra maintainers.

Please consider adding it as part of the official calligra.

Happy hacking,


Diffs (updated)
-----

  CMakeLists.txt f3a193c20c83fe8df737be838d23d9f5247c997c 
  cmake/modules/FindEigen3.cmake PRE-CREATION 
  krita/CMakeLists.txt b81e9f41c78291b284e04a613b00ba4d1c8a5191 
  krita/image/kis_perspective_math.cpp 74566e205244e92627cf84adc1360204028ddeba 
  krita/image/tests/kis_convolution_painter_test.cpp d6562dd3aef886d4173ee4f2c18692fc0ae13f82 
  krita/image/tests/kis_paint_information_test.cpp 188103c29add9bb706134ff75ae9e260af5b0de0 
  krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_ring.cpp 5f88701aea3eddcf4d3deb5059f91d12cb22fd71 
  krita/plugins/extensions/dockers/advancedcolorselector/kis_color_selector_triangle.cpp f2889b866c3d733f8fbc3ac5c93ba94061099b2c 
  krita/plugins/tools/selectiontools/kis_tool_select_brush.cc 08cd4efdc071145485abd511885546a63c44390e 
  krita/plugins/tools/selectiontools/kis_tool_select_magnetic.h d69c6b82845b00bc6e540d5daccafcc9850f4dc5 
  sheets/CMakeLists.txt 04f213f72a06c32f790c86091d97e19900a70a91 
  sheets/functions/CMakeLists.txt ba20613be6ca0c8516f19a6bcb9da861370b098b 
  sheets/functions/math.cpp 6b475f5dbc4bac22b2f6930ec25e08b302e6abe2 
  sheets/tests/CMakeLists.txt 0d1d37c09d0415c10133cc5c27dad9b3e9693eb1 

Diff: https://git.reviewboard.kde.org/r/116611/diff/


Testing
-------


Thanks,

Maximiliano Curia

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140321/fadaa586/attachment.htm>


More information about the calligra-devel mailing list