Review Request 116915: Fix Bug 305618

[Thorsten Zachmann]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116915/#review53527
-----------------------------------------------------------


In case there are questions about my comment please contact me so I can point you in the right direction.


stage/part/KPrPageApplicationData.cpp
<https://git.reviewboard.kde.org/r/116915/#comment37619>

    This is wrong. Why delete something if it is already 0? Please go back to the old code.



stage/part/tools/animationtool/KPrPageEffectDocker.cpp
<https://git.reviewboard.kde.org/r/116915/#comment37620>

    You need to create a KPrPageEffectSetCommand for every page using a seperate pageEffect as otherwise there will be problems when different pages change the effect.
    The command you create above need to add a parent command so that there is only one undo command created.


- Thorsten Zachmann


On March 20, 2014, 11:42 a.m., Wenchao Li wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116915/
> -----------------------------------------------------------
> 
> (Updated March 20, 2014, 11:42 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The patch tries to add a new function about "add this slide animation for all slides". After the checkbox is checked, the presentation will use the same slide transition for all slides.
> The function "slotApplyToAllSlides()" is defined in file KPrPageEffectDocker.cpp which implements the task.
> 
> 
> Diffs
> -----
> 
>   stage/part/KPrPageApplicationData.cpp bfda40b 
>   stage/part/tools/animationtool/KPrPageEffectDocker.h e7a5277 
>   stage/part/tools/animationtool/KPrPageEffectDocker.cpp 836d687 
> 
> Diff: https://git.reviewboard.kde.org/r/116915/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Wenchao Li
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140320/927bd8fa/attachment.htm>