Review Request 116893: On closing the content writer do not expect it to be allocated

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116893/
-----------------------------------------------------------

(Updated March 19, 2014, 9:50 p.m.)


Status
------

This change has been marked as submitted.


Review request for Calligra.


Repository: calligra


Description
-------

On closing the content writer do not expect it to be allocated

This fixes assertion in KoSimpleOdsDocument::createContent() where content stays unallocated if the filepath points to a nonwritable directory. Manifest and body are both allocated so I left the relevant assertions and conditions intact.

Needed to fix bug 332293 for 2.8.1.


Diffs
-----

  libs/odf/KoOdfWriteStore.cpp 083c8cb5230ab4a5e1ea3b7c5ee890321349e783 

Diff: https://git.reviewboard.kde.org/r/116893/diff/


Testing
-------

Documents open and save as before, tested with reports too


Thanks,

Jarosław Staniek

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140319/4aeeaaa5/attachment.htm>