Review Request 116746: Implementing "Do you want to open exported document?" question dialog after exporting report to Text/Spreadsheet/as Web Page.

Jarosław Staniek staniek at kde.org
Tue Mar 18 20:30:46 GMT 2014


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116746/#review53367
-----------------------------------------------------------

Ship it!


Good job!
Before committing to master please set up commit template if you have not done so: http://techbase.kde.org/Development/Git/Configuration#Commit_Template
Remember about structure of the commit message. Add "REVIEW:116746" line so this review closes automatically. You can add a link to the Junior Job page.

- Jarosław Staniek


On March 18, 2014, 11:24 a.m., Vishwa Modi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116746/
> -----------------------------------------------------------
> 
> (Updated March 18, 2014, 11:24 a.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The patch implements "Do you want to open exported document?" question dialog after exporting report to Text/Spreadsheet/as Web Page.
> The private function "openexporteddocument(KUrl destination)" is defined in file kexireportview.cpp which implements the task. 
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/reports/kexireportview.cpp 3e0d709 
>   kexi/plugins/reports/kexireportview.h 4d7d017 
> 
> Diff: https://git.reviewboard.kde.org/r/116746/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishwa Modi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140318/4a0936b3/attachment.htm>


More information about the calligra-devel mailing list