Review Request 116835: Implementing "Do you want to open exported document?" question dialog after exporting report to Text/Spreadsheet/as Web Page(issues resolved).

[Inge Wallin]

> On March 16, 2014, 9:34 p.m., Jarosław Staniek wrote:
> > Hi, please use "Update -> Update Diff" command on you previous review  - https://git.reviewboard.kde.org/r/116746/ - instead of opening a new one. Thanks.
> 
> Jarosław Staniek wrote:
>     Also, the rule of interaction in reviewboard is to close any issue that was opened. I opened 11 issues at https://git.reviewboard.kde.org/r/116746/.
>
> 
> Vishwa Modi wrote:
>     Hi, I have updated the previous review and have closed the issues.

Good.  But then this one isn't needed anymore, right?  If so, you should close it. 


- Inge


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116835/#review53138
-----------------------------------------------------------


On March 16, 2014, 1:49 p.m., Vishwa Modi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116835/
> -----------------------------------------------------------
> 
> (Updated March 16, 2014, 1:49 p.m.)
> 
> 
> Review request for Calligra and Jarosław Staniek.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The patch implements "Do you want to open exported document?" question dialog after exporting report to Text/Spreadsheet/as Web Page.
> The private function "openexporteddocument(KUrl destination)" is defined in file kexireportview.cpp which implements the task.
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/reports/kexireportview.h 4d7d017 
>   kexi/plugins/reports/kexireportview.cpp 3e0d709 
> 
> Diff: https://git.reviewboard.kde.org/r/116835/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishwa Modi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140318/7dc5770d/attachment.htm>