Review Request 116746: Implementing "Do you want to open exported document?" question dialog after exporting report to Text/Spreadsheet/as Web Page.

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116746/#review53266
-----------------------------------------------------------


Nicely improved! Two remaining details and we're ready to go.


kexi/plugins/reports/kexireportview.h
<https://git.reviewboard.kde.org/r/116746/#comment37468>

    just noticed, the type by convention shall be const KUrl&



kexi/plugins/reports/kexireportview.cpp
<https://git.reviewboard.kde.org/r/116746/#comment37469>

    Let's put just the default QString() here. "Kexi" will be displayed in the titlebar.


- Jarosław Staniek


On March 17, 2014, 9:16 a.m., Vishwa Modi wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116746/
> -----------------------------------------------------------
> 
> (Updated March 17, 2014, 9:16 a.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> The patch implements "Do you want to open exported document?" question dialog after exporting report to Text/Spreadsheet/as Web Page.
> The private function "openexporteddocument(KUrl destination)" is defined in file kexireportview.cpp which implements the task. 
> 
> 
> Diffs
> -----
> 
>   kexi/plugins/reports/kexireportview.h 4d7d017 
>   kexi/plugins/reports/kexireportview.cpp 3e0d709 
> 
> Diff: https://git.reviewboard.kde.org/r/116746/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Vishwa Modi
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140317/58ca1bd0/attachment.htm>