Review Request 116816: Small patches for building on Mac OS X against KDE

[RJVB Bertin]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116816/
-----------------------------------------------------------

(Updated March 16, 2014, 8:17 a.m.)


Review request for Calligra.


Changes
-------

Added a remark about the compilation of a particular file, gmic.cpp


Repository: calligra


Description (updated)
-------

Small modifications for building on Mac OS X against KDE, Qt and other libraries installed through MacPorts installed under /opt/local. MacPorts installs GLEW as a simple dylib in /opt/local/lib, FindGLEW.cmake has been modified accordingly. I installed Vc (not in MacPorts) by hand into /opt/local; the modification to FindVc.cmake is possibly redundant. The modification to kis_opengl_canvas2_p.h enables building on systems that do not have the (optional!) GLEW framework.

Note that gmic.cpp is so huge that clang 3.3 needs almost 20GB memory at some time, and takes an enormous time to compile.


Diffs
-----

  cmake/modules/FindGLEW.cmake adcc452 
  cmake/modules/FindVc.cmake bb9823f 
  krita/ui/opengl/kis_opengl_canvas2_p.h 3b1e369 

Diff: https://git.reviewboard.kde.org/r/116816/diff/


Testing
-------

With these modifications the non-packager OSX productset builds correctly on my OS X 10.6.8 system (after also modifying cmake's CMAKE_SHARED_MODULE_CREATE formulas), using the clang-3.3 compiler from MacPorts.
Basic functionality appears correct in all member applications, and 79% of the unittests succeed.

I have not tested my patch to kis_opengl_canvas2_p.h exhaustively as if figured out why GLEW wasn't found shortly after patching the file, but it's a step in the right direction if GLEW is indeed to be an optional dependency.


Thanks,

RJVB Bertin

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140316/e69aa26f/attachment.htm>