Review Request 116612: Inverted logic in the use of Testutil::compareQImages

[Boudewijn Rempt]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116612/#review52963
-----------------------------------------------------------


Thanks -- but this was fixed already :-)

- Boudewijn Rempt


On March 5, 2014, 12:31 p.m., Maximiliano Curia wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116612/
> -----------------------------------------------------------
> 
> (Updated March 5, 2014, 12:31 p.m.)
> 
> 
> Review request for Calligra.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> Hi,
> 
> the use of compareQImages in the identity test is inverted, probably due that other cmp functions return 0 on equal, instead true if equal as compareQImages does.
> 
> 
> Diffs
> -----
> 
>   krita/image/tests/kis_convolution_painter_test.cpp d6562dd3aef886d4173ee4f2c18692fc0ae13f82 
> 
> Diff: https://git.reviewboard.kde.org/r/116612/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Maximiliano Curia
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140315/73e7e0e8/attachment.htm>