Kubuntu patches

[Friedrich W. H. Kossebau]

Hi Jonathan,

Am Dienstag, 11. März 2014, 13:50:58 schrieb Jonathan Riddell:
> Congratulations on the latest 2.8 release.  Krita especially is looking very
> shiny.
> 
> We have some patches in the Kubuntu packaging I'd like reviewed and
> preferably upstreamed

> We turn on Calligra Active and package it, presumably you don't want that
> upstream but do shout if you don't want it packaged downstream
> http://bazaar.launchpad.net/~kubuntu-packagers/kubuntu-packaging/calligra/v
> iew/head:/debian/patches/kubuntu_build_calligraactive.diff

That one diff seems pretty outdated, are you sure it still applies? (did not 
look at the other)

I expect it to fail. If you want to build everything, these days the scope of 
what is built is controlled by so called product-sets, which are collections 
of all the "products" that could be generated in a build of Calligra.

There are predefined productsets, but everyone can also define their own ones, 
by adding a proper file in cmake/productsets/.
How to do so is explained in cmake/productsets/README, some info is also at
http://community.kde.org/Calligra/Building/Building_Calligra#Building_Selected_Applications

Indeed is not mentioned anywhere in README.PACKAGERS, time to add some hint 
there.

So if you want to build any products of Calligra, using the predefined "ALL" 
productset should be what you want. That is done by passing as cmake flag "-
DPRODUCTSET=ALL", but then ALL is also the default.

Deselecting products by cmake commandline options is currently not officially 
supported. Any deselection of products due to missing dependencies or other 
problems should happen in the section "Detect which products can be compile" 
in the toplevel CMakeLists.txt. If that does not work for packagers, please 
tell, surely this product set system is not yet perfect.
In any case any distri-spcific disabling patches should only be done there.

Cheers
Friedrich (who knows he wanted to brush up that system some more for some 
months now, incl. better READMEs)