Review Request 116662: Navigator docker for Words

[Jarosław Staniek]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116662/#review52411
-----------------------------------------------------------



words/part/dockers/KWNavigationWidget.h
<https://git.reviewboard.kde.org/r/116662/#comment37090>

    no need to store this variable here



words/part/dockers/KWNavigationWidget.cpp
<https://git.reviewboard.kde.org/r/116662/#comment37086>

    not needed



words/part/dockers/KWNavigationWidget.cpp
<https://git.reviewboard.kde.org/r/116662/#comment37089>

    I guess more portable way is to just use QHBoxLayout()



words/part/dockers/KWNavigationWidget.cpp
<https://git.reviewboard.kde.org/r/116662/#comment37088>

    proposed convention for clarity is to use append()



words/part/dockers/KWNavigationWidget.cpp
<https://git.reviewboard.kde.org/r/116662/#comment37087>

    instead of QString("%1").arg() we can use QString::number()
    
    +proposed convention for clarity is to use append()


- Jarosław Staniek


On March 8, 2014, 8:01 p.m., Denis Kuplyakov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116662/
> -----------------------------------------------------------
> 
> (Updated March 8, 2014, 8:01 p.m.)
> 
> 
> Review request for Calligra, Inge Wallin and Dan Leinir Turthra Jensen.
> 
> 
> Repository: calligra
> 
> 
> Description
> -------
> 
> That's the navigator docker for Words. It allow to quickly navigate through document by jumping to sections headers.
> Navigator looks through all paragraphs with outline property, and stores them in QTreeView allowing fast jump with single click.
> 
> I want some response about UI:
> 1) maybe make the rows bigger?
> 
> and about the implementation:
> 2) how can we track structure changes more effective to avoid complete rebuilding of tree?
> 3) view is flickering when updating..
> 
> 
> Diffs
> -----
> 
>   words/part/dockers/KWNavigationWidget.h PRE-CREATION 
>   words/part/dockers/KWNavigationWidget.cpp PRE-CREATION 
>   words/part/dockers/KWNavigationDocker.cpp PRE-CREATION 
>   words/part/dockers/KWNavigationDocker.h PRE-CREATION 
>   words/part/CMakeLists.txt e6e39e8 
>   words/part/KWFactory.cpp 14dfbed 
> 
> Diff: https://git.reviewboard.kde.org/r/116662/diff/
> 
> 
> Testing
> -------
> 
> Have tested it on document, containing 3 pages with many headers of different levels.
> 
> 
> File Attachments
> ----------------
> 
> Test file
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/03/08/4147a7ee-bb9b-4ff9-b809-fba7c2eb1b16__test.odt
> 
> 
> Thanks,
> 
> Denis Kuplyakov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140308/cb426549/attachment.htm>