Review Request 116009: Maintained the Aspect ratio of height and width during pdf import
Boudewijn Rempt
boud at valdyas.org
Sun Mar 2 10:20:41 GMT 2014
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116009/#review51593
-----------------------------------------------------------
Ship it!
Looks good now, I'll push it!
- Boudewijn Rempt
On March 1, 2014, 5:07 p.m., Swarn Kumar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116009/
> -----------------------------------------------------------
>
> (Updated March 1, 2014, 5:07 p.m.)
>
>
> Review request for Calligra.
>
>
> Bugs: 297254 and Bug
> http://bugs.kde.org/show_bug.cgi?id=297254
> http://bugs.kde.org/show_bug.cgi?id=Bug
>
>
> Repository: calligra
>
>
> Description
> -------
>
> Added two functions to maintain Aspect Ratio of height and width during pdf import.
>
> -heightAspectRatio()
> -widthAspectRatio()
>
> Tried to do it with c++11 lamba functions but couldn't figure it how? Compiler said the function is ambiguous.
>
>
> Diffs
> -----
>
> krita/plugins/formats/pdf/kis_pdf_import_widget.h 0458815
> krita/plugins/formats/pdf/kis_pdf_import_widget.cpp 3bba643
> krita/plugins/formats/pdf/pdfimportwidgetbase.ui 418bb04
>
> Diff: https://git.reviewboard.kde.org/r/116009/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Swarn Kumar
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/calligra-devel/attachments/20140302/669b3bbd/attachment.htm>
More information about the calligra-devel
mailing list